From mboxrd@z Thu Jan 1 00:00:00 1970 From: Pablo Neira Ayuso Subject: Re: [PATCH 4/6] netfilter: reduce NF_VERDICT_MASK to 0xff Date: Sat, 15 Jan 2011 15:29:02 +0100 Message-ID: <4D31AF2E.8030305@netfilter.org> References: <1293407904-31464-1-git-send-email-fw@strlen.de> <1293407904-31464-5-git-send-email-fw@strlen.de> <4D2DFAC5.8020802@netfilter.org> <20110112205216.GC10801@Chamillionaire.breakpoint.cc> <4D305836.8080007@trash.net> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: 7bit Cc: Florian Westphal , netfilter-devel@vger.kernel.org To: Patrick McHardy Return-path: Received: from mail.us.es ([193.147.175.20]:55406 "EHLO mail.us.es" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750795Ab1AOO3J (ORCPT ); Sat, 15 Jan 2011 09:29:09 -0500 In-Reply-To: <4D305836.8080007@trash.net> Sender: netfilter-devel-owner@vger.kernel.org List-ID: On 14/01/11 15:05, Patrick McHardy wrote: > On 12.01.2011 21:52, Florian Westphal wrote: >> Pablo Neira Ayuso wrote: >>>> /* only for userspace compatibility */ >>>> #ifndef __KERNEL__ >>>> @@ -41,6 +44,9 @@ >>>> <= 0x2000 is used for protocol-flags. */ >>>> #define NFC_UNKNOWN 0x4000 >>>> #define NFC_ALTERED 0x8000 >>>> + >>>> +/* NF_VERDICT_BITS should be 8 now, but userspace might break if this changes */ >>>> +#define NF_VERDICT_BITS 16 >>>> #endif >>> >>> i don't find any use of this in user-space. >> >> Alright, I will simply remove it, then :-) > > I think we should still keep it around in the compat section, > just because we don't know of any userspace code using this > doesn't mean it doesn't exist. Yes, that's true, but I don't fine any sane use of that macro in userspace.