From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Patrick McHardy <kaber@trash.net>
Cc: Netfilter Development Mailinglist <netfilter-devel@vger.kernel.org>
Subject: Re: netfilter: nf_conntrack: fix lifetime display for disabled connections
Date: Wed, 19 Jan 2011 19:18:33 +0100 [thread overview]
Message-ID: <4D372AF9.7020501@netfilter.org> (raw)
In-Reply-To: <4D3729AC.1090702@trash.net>
> commit f5c88f56b35599ab9ff2d3398e0153e4cd4a4c82
> Author: Patrick McHardy <kaber@trash.net>
> Date: Wed Jan 19 19:10:49 2011 +0100
>
> netfilter: nf_conntrack: fix lifetime display for disabled connections
>
> When no tstamp extension exists, ct_delta_time() returns -1, which is
> then assigned to an u64 and tested for negative values to decide
> whether to display the lifetime. This obviously doesn't work, use
> a s64 and merge the two minor functions into one.
>
> Signed-off-by: Patrick McHardy <kaber@trash.net>
I'm sorry, thanks for fixing up this case Patrick.
prev parent reply other threads:[~2011-01-19 18:18 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-19 18:13 netfilter: nf_conntrack: fix lifetime display for disabled connections Patrick McHardy
2011-01-19 18:18 ` Pablo Neira Ayuso [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D372AF9.7020501@netfilter.org \
--to=pablo@netfilter.org \
--cc=kaber@trash.net \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).