From: Patrick McHardy <kaber@trash.net>
To: Jan Engelhardt <jengelh@medozas.de>
Cc: Netfilter Developer Mailing List
<netfilter-devel@vger.kernel.org>,
Aaron Wright <wright_left@yahoo.com>,
Jon Masters <jcm@jonmasters.org>
Subject: Re: [0/5] xtables: phase out case sensitivity
Date: Wed, 19 Jan 2011 20:54:13 +0100 [thread overview]
Message-ID: <4D374165.7020504@trash.net> (raw)
In-Reply-To: <alpine.LNX.2.01.1101192023290.19837@obet.zrqbmnf.qr>
Am 19.01.2011 20:44, schrieb Jan Engelhardt:
>
> On Wednesday 2011-01-19 17:20, Patrick McHardy wrote:
>>>
>>> As a resident contributor, I stand behind the changes. In the unlikely
>>> even that it breaks, I see it as duty to fix it. The churn is on me
>>> already practically.
>>
>> It's quite likely that something breaks. Module aliases only work for
>> loading modules, not for unloading them. So there's a big chance that
>> some scripts will break.
>
> Scripts can not rely on that being successful: Xtables modules may
> pull in other modules, including using things like nf_ct_get_l3proto
> which do not leave a trace in `lsmod` output. So rmmodding of xt
> modules can fail _even_ in the present situation. Not to mention that
> scripts currently have to battle the mulitple prefixes that are in
> use (which the patchset addresses in part).
Pulling in other modules though things like nf_ct_get_l3proto()
is not a problem, you just have to flush the tables before trying
to rmmod. This works well and I've seen plenty of scripts doing
exactly that.
> Since modinfo not following aliases has bothered myself for some time
> now, I should probably just add that to m-i-t modinfo as an option and,
> while at it, rmmod.
Sure, that sounds fine to me, though it should probably follow
aliases by default instead of as an option if you want to
preserve compatiblity when renaming things.
prev parent reply other threads:[~2011-01-19 19:54 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-18 15:38 [0/5] xtables: phase out case sensitivity Jan Engelhardt
2011-01-18 15:39 ` [1/5] netfilter: xtables: avoid case-sensitive filenames (1/5) Jan Engelhardt
2011-01-18 15:39 ` [2/5] netfilter: xtables: case-sensitivity avoidance (2/5) Jan Engelhardt
2011-01-18 15:39 ` [3/5] netfilter: xtables: case-sensitivity avoidance (3/5) Jan Engelhardt
2011-01-18 15:40 ` [4/5] netfilter: xtables: case-sensitivity avoidance (4/5) Jan Engelhardt
2011-01-18 15:40 ` [5/5] netfilter: xtables: case-sensitivity avoidance (5/5) Jan Engelhardt
2011-01-18 16:16 ` [0/5] xtables: phase out case sensitivity Patrick McHardy
2011-01-18 17:37 ` Sam Roberts
2011-01-18 18:21 ` Jan Engelhardt
2011-01-18 18:37 ` Eric Dumazet
2011-01-18 18:52 ` Jan Engelhardt
2011-01-19 16:20 ` Patrick McHardy
2011-01-19 19:44 ` Jan Engelhardt
2011-01-19 19:54 ` Patrick McHardy [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D374165.7020504@trash.net \
--to=kaber@trash.net \
--cc=jcm@jonmasters.org \
--cc=jengelh@medozas.de \
--cc=netfilter-devel@vger.kernel.org \
--cc=wright_left@yahoo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).