From: Patrick McHardy <kaber@trash.net>
To: Eric Dumazet <eric.dumazet@gmail.com>
Cc: Netfilter Development Mailinglist
<netfilter-devel@vger.kernel.org>,
netdev <netdev@vger.kernel.org>,
KOVACS Krisztian <hidden@balabit.hu>
Subject: Re: [PATCH] netfilter: add a missing include in nf_conntrack_reasm.c
Date: Thu, 20 Jan 2011 21:01:42 +0100 [thread overview]
Message-ID: <4D3894A6.3040002@trash.net> (raw)
In-Reply-To: <1295553443.2613.3.camel@edumazet-laptop>
Am 20.01.2011 20:57, schrieb Eric Dumazet:
> Le jeudi 20 janvier 2011 à 20:18 +0100, Patrick McHardy a écrit :
>> Am 20.01.2011 18:53, schrieb Eric Dumazet:
>>> After commit ae90bdeaeac6b (netfilter: fix compilation when conntrack is
>>> disabled but tproxy is enabled) we have following warnings :
>>>
>>> net/ipv6/netfilter/nf_conntrack_reasm.c:520:16: warning: symbol
>>> 'nf_ct_frag6_gather' was not declared. Should it be static?
>>> net/ipv6/netfilter/nf_conntrack_reasm.c:591:6: warning: symbol
>>> 'nf_ct_frag6_output' was not declared. Should it be static?
>>> net/ipv6/netfilter/nf_conntrack_reasm.c:612:5: warning: symbol
>>> 'nf_ct_frag6_init' was not declared. Should it be static?
>>> net/ipv6/netfilter/nf_conntrack_reasm.c:640:6: warning: symbol
>>> 'nf_ct_frag6_cleanup' was not declared. Should it be static?
>>>
>>> Fix this including net/netfilter/ipv6/nf_defrag_ipv6.h
>>>
>>
>> I currently don't have access to all my trees, does this patch
>> apply to 2.6.38 or just the current -rc?
>
> I dont really understand the question.
>
> Or do you mean 2.6.37 versus 2.6.38-rc1 ?
Right, that was a typo.
> It's a minor correction anyway, not a stable candidate. It would be good
> to push it for current (2.6.38)
Applied, thanks.
I'll push this together with a bunch of other fixes to Dave later tonight.
--
To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
prev parent reply other threads:[~2011-01-20 20:01 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-20 17:53 [PATCH] netfilter: add a missing include in nf_conntrack_reasm.c Eric Dumazet
2011-01-20 19:18 ` Patrick McHardy
2011-01-20 19:57 ` Eric Dumazet
2011-01-20 20:01 ` Patrick McHardy [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D3894A6.3040002@trash.net \
--to=kaber@trash.net \
--cc=eric.dumazet@gmail.com \
--cc=hidden@balabit.hu \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).