From mboxrd@z Thu Jan 1 00:00:00 1970 From: Patrick McHardy Subject: Re: [PATCH] netfilter: ctnetlink: fix (really) race condition between dump_table and destroy Date: Mon, 24 Jan 2011 19:16:32 +0100 Message-ID: <4D3DC200.90909@trash.net> References: <20110123231602.3383.31480.stgit@decadence> <1295851305.28358.16.camel@edumazet-laptop> <4D3D691F.3050403@netfilter.org> <4D3D74AD.5080300@trash.net> <1295873689.2755.22.camel@edumazet-laptop> <4D3D794D.9010401@netfilter.org> <1295874722.2755.25.camel@edumazet-laptop> <4D3D7DD5.9020902@netfilter.org> <4D3D809F.30808@trash.net> <1295877971.2755.30.camel@edumazet-laptop> <4D3DBC94.3090505@trash.net> <1295892063.2755.37.camel@edumazet-laptop> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Cc: Pablo Neira Ayuso , netfilter-devel@vger.kernel.org, Stephen Hemminger To: Eric Dumazet Return-path: Received: from stinky.trash.net ([213.144.137.162]:35255 "EHLO stinky.trash.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753530Ab1AXSQh (ORCPT ); Mon, 24 Jan 2011 13:16:37 -0500 In-Reply-To: <1295892063.2755.37.camel@edumazet-laptop> Sender: netfilter-devel-owner@vger.kernel.org List-ID: Am 24.01.2011 19:01, schrieb Eric Dumazet: > Le lundi 24 janvier 2011 =C3=A0 18:53 +0100, Patrick McHardy a =C3=A9= crit : >=20 >> No, that can't happen. Before the last refcount is released, the ent= ry >> is removed from the hash, which requires to take the lock. Each entr= y >> contained in the hash table has a refcount of at least 1. >> >> If there are no futher concerns, I'm going to apply Pablo's patch. >=20 > Thanks, that's perfect by me >=20 > Acked-by: Eric Dumazet Applied, thanks everyone. -- To unsubscribe from this list: send the line "unsubscribe netfilter-dev= el" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html