From: Patrick McHardy <kaber@trash.net>
To: Pablo Neira Ayuso <pablo@netfilter.org>
Cc: netfilter-devel@vger.kernel.org
Subject: Re: [PATCH 1/2] netfilter: arpt_mangle: fix return values of checkentry
Date: Tue, 01 Feb 2011 16:04:55 +0100 [thread overview]
Message-ID: <4D482117.4090105@trash.net> (raw)
In-Reply-To: <20110201120526.3427.83323.stgit@decadence>
Am 01.02.2011 13:05, schrieb Pablo Neira Ayuso:
> In 135367b "netfilter: xtables: change xt_target.checkentry return type",
> the type returned by checkentry was changed from boolean to int, but the
> return values where not adjusted.
>
> # arptables -I INPUT -i eth1 --h-length 6 --destination-mac 01:00:5e:00:01:01 -j mangle --mangle-mac-d 00:18:71:68:f2:34
> arptables: Input/output error
>
> This broke arptables with the mangle target since it returns true
> under success, which is interpreted by xtables as >0, thus
> returning EIO.
Applied, thanks Pablo. I'll also push this to -stable once it hits
Linus' tree.
next prev parent reply other threads:[~2011-02-01 15:04 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-01 12:05 [PATCH 0/2] bugfixes for nf-next-2.6 (2.6.38-rc) Pablo Neira Ayuso
2011-02-01 12:05 ` [PATCH 1/2] netfilter: arpt_mangle: fix return values of checkentry Pablo Neira Ayuso
2011-02-01 15:04 ` Patrick McHardy [this message]
2011-02-01 12:05 ` [PATCH 2/2] netfilter: ecache: always set events bits, filter them later Pablo Neira Ayuso
2011-02-01 15:09 ` Patrick McHardy
2011-02-01 12:45 ` [PATCH 0/2] bugfixes for nf-next-2.6 (2.6.38-rc) Patrick McHardy
2011-02-01 12:47 ` Pablo Neira Ayuso
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D482117.4090105@trash.net \
--to=kaber@trash.net \
--cc=netfilter-devel@vger.kernel.org \
--cc=pablo@netfilter.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).