From: Patrick McHardy <kaber@trash.net>
To: Jozsef Kadlecsik <kadlec@blackhole.kfki.hu>
Cc: netfilter-devel@vger.kernel.org, Pablo Neira Ayuso <pablo@netfilter.org>
Subject: Re: [PATCH 00/13] ipset kernel patches v3
Date: Tue, 01 Feb 2011 18:42:44 +0100 [thread overview]
Message-ID: <4D484614.1000400@trash.net> (raw)
In-Reply-To: <1296514388-20900-1-git-send-email-kadlec@blackhole.kfki.hu>
Am 31.01.2011 23:52, schrieb Jozsef Kadlecsik:
> Hi,
>
> Here follows the updated ipset kernel patches. The list of changes compared
> to the previous one:
>
> - Separate ipset errnos completely from system ones and bump protocol
> version
> - Use better error codes in xt_set.c
> - Fix sparse warning about shadowed definition
> - bitmap:ip type: flavour specific adt functions
> - bitmap:port type: flavour specific adt functions
> - Move the type specificic attribute validation to the core
> - Use vzalloc() instead of __vmalloc()
> - Use meaningful error messages in xt_set.c
> - Constified attribute cannot be written
> - Send (N)ACK at dumping only when NLM_F_ACK is set
> - Correct the error codes: use ENOENT and EMSGSIZE
A few more issues I just noticed:
- There are still a bunch of purely kernel internal files
in include/linux/netfilter/ipset which should be moved to
include/net/netfilter/ipset.
- Some other include files contain mostly kernel internal
things, I'd prefer to split those and move the kernel internal
portions to include/net/netfilter/ipvs as well.
- The headers are not installed. I'm currently adding proper
Kbuild entries, will send over for review in a few minutes.
prev parent reply other threads:[~2011-02-01 17:42 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-31 22:52 [PATCH 00/13] ipset kernel patches v3 Jozsef Kadlecsik
2011-01-31 22:52 ` [PATCH 01/13] NFNL_SUBSYS_IPSET id and NLA_PUT_NET* macros Jozsef Kadlecsik
2011-01-31 22:52 ` [PATCH 02/13] IP set core support Jozsef Kadlecsik
2011-01-31 22:52 ` [PATCH 03/13] bitmap:ip set type support Jozsef Kadlecsik
2011-01-31 22:52 ` [PATCH 04/13] bitmap:ip,mac " Jozsef Kadlecsik
2011-01-31 22:53 ` [PATCH 05/13] bitmap:port set " Jozsef Kadlecsik
2011-01-31 22:53 ` [PATCH 06/13] hash:ip " Jozsef Kadlecsik
2011-01-31 22:53 ` [PATCH 07/13] hash:ip,port " Jozsef Kadlecsik
2011-01-31 22:53 ` [PATCH 08/13] hash:ip,port,ip " Jozsef Kadlecsik
2011-01-31 22:53 ` [PATCH 09/13] hash:ip,port,net " Jozsef Kadlecsik
2011-01-31 22:53 ` [PATCH 10/13] hash:net " Jozsef Kadlecsik
2011-01-31 22:53 ` [PATCH 11/13] hash:net,port " Jozsef Kadlecsik
2011-01-31 22:53 ` [PATCH 12/13] list:set " Jozsef Kadlecsik
2011-01-31 22:53 ` [PATCH 13/13] "set" match and "SET" target support Jozsef Kadlecsik
2011-02-01 14:56 ` Patrick McHardy
2011-02-01 14:55 ` [PATCH 12/13] list:set set type support Patrick McHardy
2011-02-01 14:54 ` [PATCH 11/13] hash:net,port " Patrick McHardy
2011-02-01 14:53 ` [PATCH 10/13] hash:net " Patrick McHardy
2011-02-01 14:52 ` [PATCH 09/13] hash:ip,port,net " Patrick McHardy
2011-02-01 14:42 ` [PATCH 08/13] hash:ip,port,ip " Patrick McHardy
2011-02-01 14:40 ` [PATCH 07/13] hash:ip,port " Patrick McHardy
2011-02-01 14:39 ` [PATCH 06/13] hash:ip " Patrick McHardy
2011-02-01 14:37 ` [PATCH 05/13] bitmap:port " Patrick McHardy
2011-02-01 14:36 ` [PATCH 04/13] bitmap:ip,mac " Patrick McHardy
2011-02-01 14:34 ` [PATCH 03/13] bitmap:ip set " Patrick McHardy
2011-02-01 14:31 ` [PATCH 02/13] IP set core support Patrick McHardy
2011-02-01 15:34 ` Patrick McHardy
2011-02-01 19:43 ` Jozsef Kadlecsik
2011-02-01 21:22 ` Jozsef Kadlecsik
2011-02-01 21:28 ` Jozsef Kadlecsik
2011-02-02 6:50 ` Patrick McHardy
2011-02-02 19:46 ` Jozsef Kadlecsik
2011-02-02 22:56 ` Patrick McHardy
2011-02-02 6:40 ` Patrick McHardy
2011-02-02 6:45 ` Patrick McHardy
2011-02-01 14:24 ` [PATCH 01/13] NFNL_SUBSYS_IPSET id and NLA_PUT_NET* macros Patrick McHardy
2011-02-01 14:18 ` [PATCH 00/13] ipset kernel patches v3 Patrick McHardy
2011-02-01 17:42 ` Patrick McHardy [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D484614.1000400@trash.net \
--to=kaber@trash.net \
--cc=kadlec@blackhole.kfki.hu \
--cc=netfilter-devel@vger.kernel.org \
--cc=pablo@netfilter.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).