From: Joerg Marx <joerg.marx@secunet.com>
To: Netfilter Development Mailinglist <netfilter-devel@vger.kernel.org>
Cc: Patrick McHardy <kaber@trash.net>,
"Schloegel, Robin" <robin.schloegel@secunet.com>
Subject: [PATCH] Fix a flaw in printing the MAC
Date: Thu, 17 Feb 2011 15:54:42 +0100 [thread overview]
Message-ID: <4D5D36B2.2090608@secunet.com> (raw)
The flaw was in skipping the second byte in MAC header due to increasing
the pointer AND indexed access starting at '1'.
Signed-off-by: Joerg Marx <joerg.marx@secunet.com>
---
net/ipv6/netfilter/ip6t_LOG.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/net/ipv6/netfilter/ip6t_LOG.c b/net/ipv6/netfilter/ip6t_LOG.c
index 09c8889..de33803 100644
--- a/net/ipv6/netfilter/ip6t_LOG.c
+++ b/net/ipv6/netfilter/ip6t_LOG.c
@@ -410,7 +410,7 @@ fallback:
if (p != NULL) {
sb_add(m, "%02x", *p++);
for (i = 1; i < len; i++)
- sb_add(m, ":%02x", p[i]);
+ sb_add(m, ":%02x", *p++);
}
sb_add(m, " ");
--
1.7.1
next reply other threads:[~2011-02-17 15:18 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-17 14:54 Joerg Marx [this message]
2011-02-17 15:24 ` [PATCH] Fix a flaw in printing the MAC Patrick McHardy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D5D36B2.2090608@secunet.com \
--to=joerg.marx@secunet.com \
--cc=kaber@trash.net \
--cc=netfilter-devel@vger.kernel.org \
--cc=robin.schloegel@secunet.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).