* [PATCH] Fix a flaw in printing the MAC
@ 2011-02-17 14:54 Joerg Marx
2011-02-17 15:24 ` Patrick McHardy
0 siblings, 1 reply; 2+ messages in thread
From: Joerg Marx @ 2011-02-17 14:54 UTC (permalink / raw)
To: Netfilter Development Mailinglist; +Cc: Patrick McHardy, Schloegel, Robin
The flaw was in skipping the second byte in MAC header due to increasing
the pointer AND indexed access starting at '1'.
Signed-off-by: Joerg Marx <joerg.marx@secunet.com>
---
net/ipv6/netfilter/ip6t_LOG.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/net/ipv6/netfilter/ip6t_LOG.c b/net/ipv6/netfilter/ip6t_LOG.c
index 09c8889..de33803 100644
--- a/net/ipv6/netfilter/ip6t_LOG.c
+++ b/net/ipv6/netfilter/ip6t_LOG.c
@@ -410,7 +410,7 @@ fallback:
if (p != NULL) {
sb_add(m, "%02x", *p++);
for (i = 1; i < len; i++)
- sb_add(m, ":%02x", p[i]);
+ sb_add(m, ":%02x", *p++);
}
sb_add(m, " ");
--
1.7.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] Fix a flaw in printing the MAC
2011-02-17 14:54 [PATCH] Fix a flaw in printing the MAC Joerg Marx
@ 2011-02-17 15:24 ` Patrick McHardy
0 siblings, 0 replies; 2+ messages in thread
From: Patrick McHardy @ 2011-02-17 15:24 UTC (permalink / raw)
To: Joerg Marx; +Cc: Netfilter Development Mailinglist, Schloegel, Robin
On 17.02.2011 15:54, Joerg Marx wrote:
> The flaw was in skipping the second byte in MAC header due to increasing
> the pointer AND indexed access starting at '1'.
>
Applied, thanks Jörg.
--
To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2011-02-17 15:24 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-02-17 14:54 [PATCH] Fix a flaw in printing the MAC Joerg Marx
2011-02-17 15:24 ` Patrick McHardy
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).