From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Jozsef Kadlecsik <kadlec@blackhole.kfki.hu>
Cc: netfilter-devel@vger.kernel.org,
Patrick McHardy <kaber@trash.net>,
Changli Gao <xiaosuo@gmail.com>
Subject: Re: [PATCH] netfilter: nf_ct_tcp: better handling for SYN retransmissions after SYN+ACK
Date: Sun, 27 Feb 2011 00:42:03 +0100 [thread overview]
Message-ID: <4D698FCB.6060205@netfilter.org> (raw)
In-Reply-To: <alpine.DEB.2.00.1102262238360.23113@blackhole.kfki.hu>
[-- Attachment #1: Type: text/plain, Size: 485 bytes --]
On 26/02/11 22:45, Jozsef Kadlecsik wrote:
> On Sat, 26 Feb 2011, Pablo Neira Ayuso wrote:
>> I have test it here, it works fine. Let me know if you're OK with it.
>
> The patch looks OK but I think Changli Gao is also right and it'd be
> simpler to set the [reply][synack][SR] state to sIG. What do you think?
I read his email before leaving and after I made the new patch.
Indeed, his idea is simpler, here's a new patch. I tested it here, it
works fine.
Patrick, please apply!
[-- Attachment #2: tcp-changli.patch --]
[-- Type: text/x-patch, Size: 818 bytes --]
Index: linux-2.6.37/net/netfilter/nf_conntrack_proto_tcp.c
===================================================================
--- linux-2.6.37.orig/net/netfilter/nf_conntrack_proto_tcp.c 2011-02-26 20:14:44.000000000 +0000
+++ linux-2.6.37/net/netfilter/nf_conntrack_proto_tcp.c 2011-02-26 20:15:03.000000000 +0000
@@ -227,11 +227,11 @@
* sCL -> sIV
*/
/* sNO, sSS, sSR, sES, sFW, sCW, sLA, sTW, sCL, sS2 */
-/*synack*/ { sIV, sSR, sSR, sIG, sIG, sIG, sIG, sIG, sIG, sSR },
+/*synack*/ { sIV, sSR, sIG, sIG, sIG, sIG, sIG, sIG, sIG, sSR },
/*
* sSS -> sSR Standard open.
* sS2 -> sSR Simultaneous open
- * sSR -> sSR Retransmitted SYN/ACK.
+ * sSR -> sIG Retransmitted SYN/ACK, ignore it.
* sES -> sIG Late retransmitted SYN/ACK?
* sFW -> sIG Might be SYN/ACK answering ignored SYN
* sCW -> sIG
next prev parent reply other threads:[~2011-02-26 23:43 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-26 3:32 [PATCH] improvement for TCP connection tracking Pablo Neira Ayuso
2011-02-26 3:33 ` [PATCH] netfilter: nf_ct_tcp: better handling for SYN retransmissions after SYN+ACK Pablo Neira Ayuso
2011-02-26 6:15 ` Changli Gao
2011-02-26 18:30 ` Jozsef Kadlecsik
2011-02-26 20:11 ` Pablo Neira Ayuso
2011-02-26 21:45 ` Jozsef Kadlecsik
2011-02-26 23:42 ` Pablo Neira Ayuso [this message]
2011-02-27 0:00 ` Pablo Neira Ayuso
2011-02-27 2:08 ` Igor 'Lo' (И.L.)
2011-02-27 15:22 ` Patrick McHardy
2011-02-27 17:28 ` Jozsef Kadlecsik
2011-02-28 17:04 ` Patrick McHardy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D698FCB.6060205@netfilter.org \
--to=pablo@netfilter.org \
--cc=kaber@trash.net \
--cc=kadlec@blackhole.kfki.hu \
--cc=netfilter-devel@vger.kernel.org \
--cc=xiaosuo@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).