netfilter-devel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Patrick McHardy <kaber@trash.net>
To: Jan Engelhardt <jengelh@medozas.de>
Cc: Netfilter Developer Mailing List
	<netfilter-devel@vger.kernel.org>,
	eric@inl.fr, "David S. Miller" <davem@davemloft.net>
Subject: Re: [patch] nf_log: avoid oops in (un)bind with invalid nfproto values
Date: Wed, 02 Mar 2011 12:11:59 +0100	[thread overview]
Message-ID: <4D6E25FF.6020701@trash.net> (raw)
In-Reply-To: <alpine.LNX.2.01.1102282102400.16012@obet.zrqbmnf.qr>

Am 28.02.2011 21:06, schrieb Jan Engelhardt:
> 
> The following changes since commit 41ac51eeda58a85b8a06d748cce7035cc77deebd
> (kaber/nf-next-2.6 @ 2.6.38-rc1+):
> 
>   ipvs: make "no destination available" message more informative (2011-02-16 14:53:33 +0900)
> 
> are available in the git repository at:
>   git://dev.medozas.de/linux master
> 
> Jan Engelhardt (1):
>       netfilter: nf_log: avoid oops in (un)bind with invalid nfproto values
> 

Since this fixes an oops, I've applied it to nf-2.6.git instead
of nf-next-2.6.git.

>  void nf_log_unbind_pf(u_int8_t pf)
>  {
> +	if (pf >= ARRAY_SIZE(nf_loggers))
> +		return -EINVAL;

I also fixed a warning, nf_log_unbind_pf is void.

>  	mutex_lock(&nf_log_mutex);
>  	rcu_assign_pointer(nf_loggers[pf], NULL);
>  	mutex_unlock(&nf_log_mutex);


      reply	other threads:[~2011-03-02 11:12 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-02-28 20:06 [patch] nf_log: avoid oops in (un)bind with invalid nfproto values Jan Engelhardt
2011-03-02 11:11 ` Patrick McHardy [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4D6E25FF.6020701@trash.net \
    --to=kaber@trash.net \
    --cc=davem@davemloft.net \
    --cc=eric@inl.fr \
    --cc=jengelh@medozas.de \
    --cc=netfilter-devel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).