* [PATCH] netfilter:ipset: fix the compile warning in ip_set_create @ 2011-03-04 7:34 Shan Wei 2011-03-04 9:00 ` Jozsef Kadlecsik 0 siblings, 1 reply; 4+ messages in thread From: Shan Wei @ 2011-03-04 7:34 UTC (permalink / raw) To: Patrick McHardy, netfilter-devel, Jozsef Kadlecsik, Jozsef Kadlecsik net/netfilter/ipset/ip_set_core.c:615: warning: ‘clash’ may be used uninitialized in this function Signed-off-by: shanw <shanw@shanw-desktop.(none)> --- net/netfilter/ipset/ip_set_core.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/net/netfilter/ipset/ip_set_core.c b/net/netfilter/ipset/ip_set_core.c index 8b1a54c..618a615 100644 --- a/net/netfilter/ipset/ip_set_core.c +++ b/net/netfilter/ipset/ip_set_core.c @@ -612,7 +612,7 @@ ip_set_create(struct sock *ctnl, struct sk_buff *skb, const struct nlmsghdr *nlh, const struct nlattr * const attr[]) { - struct ip_set *set, *clash; + struct ip_set *set, *clash = NULL; ip_set_id_t index = IPSET_INVALID_ID; struct nlattr *tb[IPSET_ATTR_CREATE_MAX+1] = {}; const char *name, *typename; -- 1.6.3.3 -- To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] netfilter:ipset: fix the compile warning in ip_set_create 2011-03-04 7:34 [PATCH] netfilter:ipset: fix the compile warning in ip_set_create Shan Wei @ 2011-03-04 9:00 ` Jozsef Kadlecsik 2011-03-04 11:27 ` Shan Wei 0 siblings, 1 reply; 4+ messages in thread From: Jozsef Kadlecsik @ 2011-03-04 9:00 UTC (permalink / raw) To: Shan Wei; +Cc: Patrick McHardy, netfilter-devel On Fri, 4 Mar 2011, Shan Wei wrote: > net/netfilter/ipset/ip_set_core.c:615: warning: ?clash? may be used uninitialized in this function > > Signed-off-by: shanw <shanw@shanw-desktop.(none)> > --- > net/netfilter/ipset/ip_set_core.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/net/netfilter/ipset/ip_set_core.c b/net/netfilter/ipset/ip_set_core.c > index 8b1a54c..618a615 100644 > --- a/net/netfilter/ipset/ip_set_core.c > +++ b/net/netfilter/ipset/ip_set_core.c > @@ -612,7 +612,7 @@ ip_set_create(struct sock *ctnl, struct sk_buff *skb, > const struct nlmsghdr *nlh, > const struct nlattr * const attr[]) > { > - struct ip_set *set, *clash; > + struct ip_set *set, *clash = NULL; > ip_set_id_t index = IPSET_INVALID_ID; > struct nlattr *tb[IPSET_ATTR_CREATE_MAX+1] = {}; > const char *name, *typename; > -- > 1.6.3.3 Thanks, I applied your patch in my tree. Patrick, please apply it too. Signed-off-by: Jozsef Kadlecsik <kadlec@blackhole.kfki.hu> Best regards, Jozsef - E-mail : kadlec@blackhole.kfki.hu, kadlec@mail.kfki.hu PGP key : http://www.kfki.hu/~kadlec/pgp_public_key.txt Address : KFKI Research Institute for Particle and Nuclear Physics H-1525 Budapest 114, POB. 49, Hungary ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] netfilter:ipset: fix the compile warning in ip_set_create 2011-03-04 9:00 ` Jozsef Kadlecsik @ 2011-03-04 11:27 ` Shan Wei 2011-03-08 14:38 ` Patrick McHardy 0 siblings, 1 reply; 4+ messages in thread From: Shan Wei @ 2011-03-04 11:27 UTC (permalink / raw) To: Jozsef Kadlecsik; +Cc: Patrick McHardy, netfilter-devel Jozsef Kadlecsik wrote, at 03/04/2011 05:00 PM: > On Fri, 4 Mar 2011, Shan Wei wrote: > >> net/netfilter/ipset/ip_set_core.c:615: warning: ?clash? may be used uninitialized in this function >> >> Signed-off-by: shanw <shanw@shanw-desktop.(none)> >> --- >> net/netfilter/ipset/ip_set_core.c | 2 +- >> 1 files changed, 1 insertions(+), 1 deletions(-) >> >> diff --git a/net/netfilter/ipset/ip_set_core.c b/net/netfilter/ipset/ip_set_core.c >> index 8b1a54c..618a615 100644 >> --- a/net/netfilter/ipset/ip_set_core.c >> +++ b/net/netfilter/ipset/ip_set_core.c >> @@ -612,7 +612,7 @@ ip_set_create(struct sock *ctnl, struct sk_buff *skb, >> const struct nlmsghdr *nlh, >> const struct nlattr * const attr[]) >> { >> - struct ip_set *set, *clash; >> + struct ip_set *set, *clash = NULL; >> ip_set_id_t index = IPSET_INVALID_ID; >> struct nlattr *tb[IPSET_ATTR_CREATE_MAX+1] = {}; >> const char *name, *typename; >> -- >> 1.6.3.3 > > Thanks, I applied your patch in my tree. > > Patrick, please apply it too. > > Signed-off-by: Jozsef Kadlecsik <kadlec@blackhole.kfki.hu> > Thanks for your review. Bad sob in first patch, fix it in new one. ================ [PATCH v2] netfilter:ipset: fix the compile warning in ip_set_create net/netfilter/ipset/ip_set_core.c:615: warning: ‘clash’ may be used uninitialized in this function Signed-off-by: Shan Wei <shanwei@cn.fujitsu.com> Signed-off-by: Jozsef Kadlecsik <kadlec@blackhole.kfki.hu> --- net/netfilter/ipset/ip_set_core.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/net/netfilter/ipset/ip_set_core.c b/net/netfilter/ipset/ip_set_core.c index 8b1a54c..618a615 100644 --- a/net/netfilter/ipset/ip_set_core.c +++ b/net/netfilter/ipset/ip_set_core.c @@ -612,7 +612,7 @@ ip_set_create(struct sock *ctnl, struct sk_buff *skb, const struct nlmsghdr *nlh, const struct nlattr * const attr[]) { - struct ip_set *set, *clash; + struct ip_set *set, *clash = NULL; ip_set_id_t index = IPSET_INVALID_ID; struct nlattr *tb[IPSET_ATTR_CREATE_MAX+1] = {}; const char *name, *typename; -- To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] netfilter:ipset: fix the compile warning in ip_set_create 2011-03-04 11:27 ` Shan Wei @ 2011-03-08 14:38 ` Patrick McHardy 0 siblings, 0 replies; 4+ messages in thread From: Patrick McHardy @ 2011-03-08 14:38 UTC (permalink / raw) To: Shan Wei; +Cc: Jozsef Kadlecsik, netfilter-devel Am 04.03.2011 12:27, schrieb Shan Wei: >> > Thanks, I applied your patch in my tree. >> > >> > Patrick, please apply it too. >> > >> > Signed-off-by: Jozsef Kadlecsik <kadlec@blackhole.kfki.hu> >> > > Thanks for your review. > Bad sob in first patch, fix it in new one. > > ================ > [PATCH v2] netfilter:ipset: fix the compile warning in ip_set_create > > net/netfilter/ipset/ip_set_core.c:615: warning: ‘clash’ may be used uninitialized in this function > > Signed-off-by: Shan Wei <shanwei@cn.fujitsu.com> > Signed-off-by: Jozsef Kadlecsik <kadlec@blackhole.kfki.hu> Applied, thanks. -- To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2011-03-08 14:38 UTC | newest] Thread overview: 4+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2011-03-04 7:34 [PATCH] netfilter:ipset: fix the compile warning in ip_set_create Shan Wei 2011-03-04 9:00 ` Jozsef Kadlecsik 2011-03-04 11:27 ` Shan Wei 2011-03-08 14:38 ` Patrick McHardy
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).