From: Patrick McHardy <kaber@trash.net>
To: Florian Westphal <fw@strlen.de>
Cc: netfilter-devel@vger.kernel.org
Subject: Re: [PATCH v2 2/2] netfilter: xt_addrtype: ipv6 support.
Date: Tue, 15 Mar 2011 14:30:03 +0100 [thread overview]
Message-ID: <4D7F69DB.7070606@trash.net> (raw)
In-Reply-To: <20110310222204.GZ8821@Chamillionaire.breakpoint.cc>
On 10.03.2011 23:22, Florian Westphal wrote:
> Florian Westphal <fw@strlen.de> wrote:
>> diff --git a/net/netfilter/xt_addrtype.c b/net/netfilter/xt_addrtype.c
>> index e89c0b8..2220b85 100644
>> --- a/net/netfilter/xt_addrtype.c
>> +++ b/net/netfilter/xt_addrtype.c
> [..]
>> + if ((XT_ADDRTYPE_LOCAL | XT_ADDRTYPE_ANYCAST |
>> + XT_ADDRTYPE_UNREACHABLE) & mask) {
>> + struct rt6_info *rt;
>> + u32 type;
>> + int ifindex = dev ? dev->ifindex : 0;
>> +
>> + rt = rt6_lookup(net, addr, NULL, ifindex, !!dev);
>> +
>
> This needs a Kconfig
> depends on (IPV6 || IPV6=n)
>
> to avoid linker errors for the ipv6=m and xt_addrtype=y case.
>
> Patrick, I'll refrain from sending v3 for now in case any other changes
> might be needed.
>
> Please let me know if you want me to send a V3 with the Kconfig change
> only.
Please do, I plan to submit my remaining patches for 2.6.39 tonight.
prev parent reply other threads:[~2011-03-15 13:30 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-08 21:17 [PATCH v2 1/2] netfilter: ipt_addrtype: rename to xt_addrtype Florian Westphal
2011-03-08 21:17 ` [PATCH v2 2/2] netfilter: xt_addrtype: ipv6 support Florian Westphal
2011-03-10 22:22 ` Florian Westphal
2011-03-15 13:30 ` Patrick McHardy [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D7F69DB.7070606@trash.net \
--to=kaber@trash.net \
--cc=fw@strlen.de \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).