From mboxrd@z Thu Jan  1 00:00:00 1970
From: Patrick McHardy <kaber@trash.net>
Subject: Re: [PATCH v3 2/2] netfilter: xt_addrtype: ipv6 support
Date: Sun, 20 Mar 2011 15:39:07 +0100
Message-ID: <4D86118B.4070605@trash.net>
References: <1300214971-20345-1-git-send-email-fw@strlen.de> <1300214971-20345-2-git-send-email-fw@strlen.de> <4D80C12E.4010107@trash.net> <20110318232653.GC13371@Chamillionaire.breakpoint.cc>
Mime-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Cc: netfilter-devel@vger.kernel.org
To: Florian Westphal <fw@strlen.de>
Return-path: <netfilter-devel-owner@vger.kernel.org>
Received: from stinky.trash.net ([213.144.137.162]:44622 "EHLO
	stinky.trash.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1751609Ab1CTOjJ (ORCPT
	<rfc822;netfilter-devel@vger.kernel.org>);
	Sun, 20 Mar 2011 10:39:09 -0400
In-Reply-To: <20110318232653.GC13371@Chamillionaire.breakpoint.cc>
Sender: netfilter-devel-owner@vger.kernel.org
List-ID: <netfilter-devel.vger.kernel.org>

Am 19.03.2011 00:26, schrieb Florian Westphal:
> Patrick McHardy <kaber@trash.net> wrote:
>> On 15.03.2011 19:49, Florian Westphal wrote:
> [..]
>>> +		rt = rt6_lookup(net, addr, NULL, ifindex, !!dev);
>>
>> Florian, I just noticed that this will pull in the IPv6 module just
>> by loading the xt_addrtype module. Can we convert this to use
>> nf_ip6_afinfo->route() instead?
> 
> I tried this, but i found two issues:
> - no netns support (nf_ip6_route passed init_net)
> - its not possible to ask for RT6_LOOKUP_F_IFACE flag in the
>   underlying fib6_rule_lookup() call.
> 
> But AFAICT the latter is needed to support the '--limit-iface-in/out'
> option.
> 
> Any idea?
> 
> Otherwise I think I'll have a go at extending afinfo->route() to pass
> in struct net* and a 'strict' argument (i.e. what rt6_lookup() has).
> 
> Unfortunately that would have to wait for 2.6.40...

Actually I'd consider that (especially the struct net *) a bugfix
since we shouldn't be pulling in the IPv6 module.