From mboxrd@z Thu Jan 1 00:00:00 1970 From: Patrick McHardy Subject: Re: [PATCH v2] ipv4: netfilter: ipt_CLUSTERIP: fix buffer overflow Date: Sun, 20 Mar 2011 15:43:36 +0100 Message-ID: <4D861298.1040700@trash.net> References: <1299780740-32652-1-git-send-email-segoon@openwall.com> <4D7F5CAC.6070006@trash.net> <20110317113229.GA7710@albatros> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: Vasiliy Kulikov , linux-kernel@vger.kernel.org, security@kernel.org, "David S. Miller" , Alexey Kuznetsov , James Morris , Hideaki YOSHIFUJI , netfilter-devel@vger.kernel.org, netfilter@vger.kernel.org, coreteam@netfilter.org, netdev@vger.kernel.org To: Changli Gao Return-path: Received: from stinky.trash.net ([213.144.137.162]:44694 "EHLO stinky.trash.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751726Ab1CTOnm (ORCPT ); Sun, 20 Mar 2011 10:43:42 -0400 In-Reply-To: Sender: netfilter-devel-owner@vger.kernel.org List-ID: Am 17.03.2011 13:15, schrieb Changli Gao: > On Thu, Mar 17, 2011 at 7:32 PM, Vasiliy Kulikov wrote: >> 'buffer' string is copied from userspace. It is not checked whether it is >> zero terminated. This may lead to overflow inside of simple_strtoul(). >> Changli Gao suggested to copy not more than user supplied 'size' bytes. >> >> It was introduced before the git epoch. Files "ipt_CLUSTERIP/*" are >> root writable only by default, however, on some setups permissions might be >> relaxed to e.g. network admin user. >> >> Signed-off-by: Vasiliy Kulikov > Acked-by: Changli Gao > > Applied, thanks everyone.