From: Patrick McHardy <kaber@trash.net>
To: Florian Westphal <fwestphal@astaro.com>
Cc: netfilter-devel@vger.kernel.org
Subject: Re: [PATCH] netfilter: xt_conntrack: fix inverted conntrack direction test
Date: Mon, 04 Apr 2011 17:07:06 +0200 [thread overview]
Message-ID: <4D99DE9A.8050408@trash.net> (raw)
In-Reply-To: <1301926740-22216-1-git-send-email-fwestphal@astaro.com>
On 04.04.2011 16:19, Florian Westphal wrote:
> --ctdir ORIGINAL matches REPLY packets, and vv:
>
> userspace sets "invert_flags &= ~XT_CONNTRACK_DIRECTION" in ORIGINAL
> case.
>
> Thus: (CTINFO2DIR(ctinfo) == IP_CT_DIR_ORIGINAL) ^
> !!(info->invert_flags & XT_CONNTRACK_DIRECTION))
>
> yields "1 ^ 0", which is true -> returns false.
>
> Reproducer:
> iptables -I OUTPUT 1 -p tcp --syn -m conntrack --ctdir ORIGINAL
Applied, thanks Florian.
prev parent reply other threads:[~2011-04-04 15:07 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-04 14:19 [PATCH] netfilter: xt_conntrack: fix inverted conntrack direction test Florian Westphal
2011-04-04 15:07 ` Patrick McHardy [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D99DE9A.8050408@trash.net \
--to=kaber@trash.net \
--cc=fwestphal@astaro.com \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).