From: Patrick McHardy <kaber@trash.net>
To: Jozsef Kadlecsik <kadlec@blackhole.kfki.hu>
Cc: netfilter-devel@vger.kernel.org,
Lennert Buytenhek <buytenh@wantstofly.org>
Subject: Re: [PATCH 1/3] netfilter: ipset: bitmap:ip,mac type requires "src" for MAC
Date: Wed, 13 Apr 2011 13:44:03 +0200 [thread overview]
Message-ID: <4DA58C83.2000702@trash.net> (raw)
In-Reply-To: <1302379382-32338-2-git-send-email-kadlec@blackhole.kfki.hu>
Am 09.04.2011 22:03, schrieb Jozsef Kadlecsik:
> Enforce that the second "src/dst" parameter of the set match and SET target
> must be "src", because we have access to the source MAC only in the packet.
> The previous behaviour, that the type required the second parameter
> but actually ignored the value was counter-intuitive and confusing.
>
Applied, thanks Jozsef.
next prev parent reply other threads:[~2011-04-13 11:44 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-09 20:02 [PATCH 0/3] netfilter: ipset: fixes Jozsef Kadlecsik
2011-04-09 20:03 ` [PATCH 1/3] netfilter: ipset: bitmap:ip,mac type requires "src" for MAC Jozsef Kadlecsik
2011-04-09 20:03 ` [PATCH 2/3] netfilter: ipset: Whitespace fixes: some space before tab slipped in Jozsef Kadlecsik
2011-04-09 20:03 ` [PATCH 3/3] netfilter: ipset: set match and SET target fixes Jozsef Kadlecsik
2011-04-13 11:47 ` Patrick McHardy
2011-04-13 11:46 ` [PATCH 2/3] netfilter: ipset: Whitespace fixes: some space before tab slipped in Patrick McHardy
2011-04-13 11:44 ` Patrick McHardy [this message]
-- strict thread matches above, loose matches on Subject: below --
2011-04-19 14:51 [PATCH 0/3] netfilter: netfilter fixes for 2.6.39-rc4 kaber
2011-04-19 14:51 ` [PATCH 1/3] netfilter: ipset: bitmap:ip,mac type requires "src" for MAC kaber
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4DA58C83.2000702@trash.net \
--to=kaber@trash.net \
--cc=buytenh@wantstofly.org \
--cc=kadlec@blackhole.kfki.hu \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).