From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Patrick McHardy <kaber@trash.net>
Cc: netfilter-devel@vger.kernel.org
Subject: Re: [PATCH 0/2] rework of userspace expectation support
Date: Wed, 13 Apr 2011 13:47:20 +0200 [thread overview]
Message-ID: <4DA58D48.4010307@netfilter.org> (raw)
In-Reply-To: <4DA58AE2.7000204@trash.net>
On 13/04/11 13:37, Patrick McHardy wrote:
> Am 12.04.2011 23:59, schrieb Pablo Neira Ayuso:
>> Hi Patrick,
>>
>> The following patches rework the userspace expectation support
>> to fix one problematic scenario: if the master conntrack vanishes
>> while there are still userspace expectations, we hit an oops
>> in the destroy event path for expectations.
>
> Just wondering, how can this happen? We take a reference for
> userspace expectations just as we do for kernel expectations.
>
> Ok, I see, we are releasing it again at the end of
> ctnetlink_create_expect(), that seems to be the actual problem
> if I'm not mistaken.
Indeed, we have keep that reference, that would fix the problem.
Still, with the curent approach the userspace expectation will be valid
after the master conntrack has expired.
So we can do the following: Fix this refcount issue in -stable and
current, and schedule these patches for nf-next to change the behaviour.
What do you think?
next prev parent reply other threads:[~2011-04-13 11:47 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-12 21:59 [PATCH 0/2] rework of userspace expectation support Pablo Neira Ayuso
2011-04-12 21:59 ` [PATCH 1/2] netfilter: CT: allow to set userspace helper status flag Pablo Neira Ayuso
2011-04-12 21:59 ` [PATCH 2/2] netfilter: nf_ct_expect: rework userspace expectation support Pablo Neira Ayuso
2011-04-13 11:37 ` [PATCH 0/2] rework of " Patrick McHardy
2011-04-13 11:47 ` Pablo Neira Ayuso [this message]
2011-04-13 11:55 ` Patrick McHardy
2011-04-13 12:11 ` Pablo Neira Ayuso
2011-04-13 12:28 ` Patrick McHardy
2011-04-13 20:02 ` Pablo Neira Ayuso
2011-04-20 12:10 ` Pablo Neira Ayuso
2011-04-20 14:06 ` Patrick McHardy
2011-04-21 13:14 ` Pablo Neira Ayuso
2011-05-17 21:12 ` Sam Roberts
2011-06-13 21:57 ` Sam Roberts
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4DA58D48.4010307@netfilter.org \
--to=pablo@netfilter.org \
--cc=kaber@trash.net \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).