From: Patrick McHardy <kaber@trash.net>
To: "Maciej Żenczykowski" <zenczykowski@gmail.com>
Cc: "Maciej Żenczykowski" <maze@google.com>, netfilter-devel@vger.kernel.org
Subject: Re: [PATCH 1/5] Don't load ip6?_tables module when already loaded.
Date: Tue, 19 Apr 2011 09:03:21 +0200 [thread overview]
Message-ID: <4DAD33B9.3030802@trash.net> (raw)
In-Reply-To: <1303176233-14063-1-git-send-email-zenczykowski@gmail.com>
On 19.04.2011 03:23, Maciej Żenczykowski wrote:
> From: Maciej Żenczykowski <maze@google.com>
>
> Signed-off-by: Maciej Zenczykowski <maze@google.com>
> ---
> xshared.h | 2 ++
> xtables.c | 34 +++++++++++++++++++++++++++++-----
> 2 files changed, 31 insertions(+), 5 deletions(-)
>
> +/* return true if a given file exists within procfs */
> +static bool proc_file_exists(const char *filename)
> +{
> + struct stat s;
> + struct statfs f;
> +
> + if (lstat(filename, &s)) return false;
Please put these return statements on lines of their own.
> + if (!S_ISREG(s.st_mode)) return false;
> + if (statfs(filename, &f)) return false;
> + if (f.f_type != PROC_SUPER_MAGIC) return false;
> + return true;
> +}
> +
--
To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2011-04-19 7:03 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-19 1:22 Patches: don't call modprobe, ipv4/ipv6 flag support, xtables-multi unification Maciej Żenczykowski
2011-04-19 1:23 ` [PATCH 1/5] Don't load ip6?_tables module when already loaded Maciej Żenczykowski
2011-04-19 7:03 ` Patrick McHardy [this message]
2011-04-19 7:10 ` [PATCH] " Maciej Żenczykowski
2011-04-19 7:14 ` Patrick McHardy
2011-04-19 1:23 ` [PATCH 2/5] Add --ipv4/-4 and --ipv6/-6 support to ip6?tables{,-restore} Maciej Żenczykowski
2011-04-19 7:17 ` Patrick McHardy
2011-04-19 7:32 ` Maciej Żenczykowski
2011-04-19 7:33 ` Patrick McHardy
2011-04-19 1:23 ` [PATCH 3/5] Move common parts of libext{4,6}.a into libext.a Maciej Żenczykowski
2011-04-19 1:23 ` [PATCH 4/5] combine ip6?tables-multi into xtables-multi Maciej Żenczykowski
2011-04-19 1:23 ` [PATCH 5/5] add xtables-multi{32,64} recognition Maciej Żenczykowski
2011-04-19 7:18 ` Patrick McHardy
2011-04-19 7:29 ` Maciej Żenczykowski
2011-04-19 7:32 ` Patrick McHardy
2011-04-19 7:55 ` Jan Engelhardt
2011-04-19 8:55 ` Maciej Żenczykowski
2011-04-20 1:44 ` Patches: don't call modprobe, ipv4/ipv6 flag support, xtables-multi unification Maciej Żenczykowski
2011-04-20 1:44 ` [PATCH 1/3] Add --ipv4/-4 and --ipv6/-6 support to ip6?tables{,-restore} Maciej Żenczykowski
2011-04-20 1:44 ` [PATCH 2/3] Move common parts of libext{4,6}.a into libext.a Maciej Żenczykowski
2011-04-20 1:44 ` [PATCH 3/3] combine ip6?tables-multi into xtables-multi Maciej Żenczykowski
2011-04-21 9:16 ` Patches: don't call modprobe, ipv4/ipv6 flag support, xtables-multi unification Patrick McHardy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4DAD33B9.3030802@trash.net \
--to=kaber@trash.net \
--cc=maze@google.com \
--cc=netfilter-devel@vger.kernel.org \
--cc=zenczykowski@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).