From mboxrd@z Thu Jan 1 00:00:00 1970 From: Pablo Neira Ayuso Subject: Re: [PATCH 0/2] rework of userspace expectation support Date: Wed, 20 Apr 2011 14:10:42 +0200 Message-ID: <4DAECD42.9080006@netfilter.org> References: <20110412215458.3145.40830.stgit@decadence> <4DA58AE2.7000204@trash.net> <4DA58D48.4010307@netfilter.org> <4DA58F41.9080603@trash.net> <4DA592F3.1090201@netfilter.org> <4DA59700.9000400@trash.net> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Cc: netfilter-devel@vger.kernel.org To: Patrick McHardy Return-path: Received: from mail.us.es ([193.147.175.20]:60370 "EHLO mail.us.es" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751862Ab1DTMLX (ORCPT ); Wed, 20 Apr 2011 08:11:23 -0400 In-Reply-To: <4DA59700.9000400@trash.net> Sender: netfilter-devel-owner@vger.kernel.org List-ID: On 13/04/11 14:28, Patrick McHardy wrote: > I see, you're talking about unfulfilled expectations. Still, we're > releasing expectations in destroy_conntrack(), if we fix the refcount > issue, the master conntrack will not be destroyed while userspace > expectations exist. I missed one point. We don't seem to increase the refcnt for unfulfilled expectations. The following example shows a unfulfilled FTP expectation: # conntrack -L exp 262 proto=6 src=192.168.1.128 dst=130.89.149.226 sport=0 dport=20412 conntrack v1.0.0 (conntrack-tools): 1 expectations have been shown. # conntrack -L tcp 6 431979 ESTABLISHED src=192.168.1.128 dst=130.89.149.226 sport=37348 dport=21 packets=9 bytes=503 src=130.89.149.226 dst=192.168.1.128 sport=21 dport=37348 packets=8 bytes=564 [ASSURED] mark=0 delta-time=29 use=1 The use field of the master conntrack shows 1. So, I think that these patches are still the way to fix the problem with the expectations created through ctnetlink.