From: Patrick McHardy <kaber@trash.net>
To: Florian Westphal <fw@strlen.de>
Cc: netfilter-devel@vger.kernel.org
Subject: Re: [PATCH 1/1] netfilter: ebtables: only call xt_compat_add_offset once per rule
Date: Thu, 21 Apr 2011 10:59:16 +0200 [thread overview]
Message-ID: <4DAFF1E4.6010703@trash.net> (raw)
In-Reply-To: <1302121610-18057-1-git-send-email-fw@strlen.de>
On 06.04.2011 22:26, Florian Westphal wrote:
> The optimizations in commit 255d0dc34068a976
> (netfilter: x_table: speedup compat operations) assume that
> xt_compat_add_offset is called once per rule.
>
> ebtables however called it for each match/target found in a rule.
>
> The match/watcher/target parser already returns the needed delta, so it
> is sufficient to move the xt_compat_add_offset call to a more reasonable
> location.
>
> While at it, also get rid of the unused COMPAT iterator macros.
Applied, thanks Florian.
prev parent reply other threads:[~2011-04-21 8:59 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-06 20:26 [PATCH 1/1] netfilter: ebtables: only call xt_compat_add_offset once per rule Florian Westphal
2011-04-21 8:59 ` Patrick McHardy [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4DAFF1E4.6010703@trash.net \
--to=kaber@trash.net \
--cc=fw@strlen.de \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).