From: Jeff Mahoney <jeffm@suse.com>
To: Jan Engelhardt <jengelh@medozas.de>
Cc: netfilter-devel@vger.kernel.org
Subject: Re: [PATCH] netfilter: Implement RFC 1123 for FTP conntrack
Date: Fri, 06 May 2011 13:50:38 -0400 [thread overview]
Message-ID: <4DC434EE.5050506@suse.com> (raw)
In-Reply-To: <alpine.LNX.2.01.1105061943560.22432@obet.zrqbmnf.qr>
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
On 05/06/2011 01:45 PM, Jan Engelhardt wrote:
> On Friday 2011-05-06 19:38, Jeff Mahoney wrote:
>
>> The FTP conntrack code currently only accepts the following format for
>> the 227 response for PASV:
>> 227 Entering Passive Mode (148,100,81,40,31,161).
>>
>> It doesn't accept the following format from an obscure server:
>> 227 Data transfer will passively listen to 67,218,99,134,50,144
>>
>>From RFC 1123: The format of the 227 reply to a PASV command is not
>> well standardized. In particular, an FTP client cannot assume that the
>> parentheses shown on page 40 of RFC-959 will be present (and in fact,
>> Figure 3 on page 43 omits them). Therefore, a User-FTP program that
>> interprets the PASV reply must scan the reply for the first digit of
>> the host and port numbers.
>>
>> This patch adds support for the RFC 1123 clarification[...]
>>
>> Tracked in: https://bugzilla.novell.com/show_bug.cgi?id=466279
>
> "You are not authorized to access bug #466279."
Hrm. I'm afraid I can't do anything about that. I don't have permissions
to open it up. It's mostly just clarification.
The summary is just that the second 227 response above doesn't get
properly handled without the patch and does with it. I can re-submit
without the reference if needed.
- -Jeff
- --
Jeff Mahoney
SUSE Labs
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.17 (GNU/Linux)
Comment: Using GnuPG with SUSE - http://enigmail.mozdev.org/
iEYEARECAAYFAk3ENO4ACgkQLPWxlyuTD7LjrQCfcncHTbLxovQ2UqXfxJ1EiJAQ
BlUAnikJGLCGOrrzeP1ryohuovFvFT/m
=9xWX
-----END PGP SIGNATURE-----
prev parent reply other threads:[~2011-05-06 17:50 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-06 17:38 [PATCH] netfilter: Implement RFC 1123 for FTP conntrack Jeff Mahoney
2011-05-06 17:45 ` Jan Engelhardt
2011-05-06 17:50 ` Jeff Mahoney [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4DC434EE.5050506@suse.com \
--to=jeffm@suse.com \
--cc=jengelh@medozas.de \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).