From: Patrick McHardy <kaber@trash.net>
To: Jan Engelhardt <jengelh@medozas.de>
Cc: netfilter-devel@vger.kernel.org
Subject: Re: [PATCH 10/13] libxt_rateest: avoid optional arguments
Date: Tue, 24 May 2011 08:46:05 +0200 [thread overview]
Message-ID: <4DDB542D.5060006@trash.net> (raw)
In-Reply-To: <1306161564-4370-11-git-send-email-jengelh@medozas.de>
On 23.05.2011 16:39, Jan Engelhardt wrote:
> Optional arguments make parsing unnecessarily harder - even more so
> than two-args. Right now, rateest even crashes because of it.
>
> static const struct option rateest_opts[] = {
> {.name = "rateest1", .has_arg = true, .val = OPT_RATEEST1},
> {.name = "rateest", .has_arg = true, .val = OPT_RATEEST1}, /* alias for absolute mode */
> {.name = "rateest2", .has_arg = true, .val = OPT_RATEEST2},
> - {.name = "rateest-bps1", .has_arg = false, .val = OPT_RATEEST_BPS1},
> - {.name = "rateest-pps1", .has_arg = false, .val = OPT_RATEEST_PPS1},
> - {.name = "rateest-bps2", .has_arg = false, .val = OPT_RATEEST_BPS2},
> - {.name = "rateest-pps2", .has_arg = false, .val = OPT_RATEEST_PPS2},
> - {.name = "rateest-bps", .has_arg = false, .val = OPT_RATEEST_BPS2}, /* alias for absolute mode */
> - {.name = "rateest-pps", .has_arg = false, .val = OPT_RATEEST_PPS2}, /* alias for absolute mode */
> + {.name = "rateest-bps1", .has_arg = true, .val = OPT_RATEEST_BPS1},
> + {.name = "rateest-pps1", .has_arg = true, .val = OPT_RATEEST_PPS1},
> + {.name = "rateest-bps2", .has_arg = true, .val = OPT_RATEEST_BPS2},
> + {.name = "rateest-pps2", .has_arg = true, .val = OPT_RATEEST_PPS2},
> + {.name = "rateest-bps", .has_arg = true, .val = OPT_RATEEST_BPS2}, /* alias for absolute mode */
> + {.name = "rateest-pps", .has_arg = true, .val = OPT_RATEEST_PPS2}, /* alias for absolute mode */
> {.name = "rateest-delta", .has_arg = false, .val = OPT_RATEEST_DELTA},
> {.name = "rateest-lt", .has_arg = false, .val = OPT_RATEEST_LT},
> {.name = "rateest-gt", .has_arg = false, .val = OPT_RATEEST_GT},
> {.name = "rateest-eq", .has_arg = false, .val = OPT_RATEEST_EQ},
> + {.name = "bytes", .has_arg = false, .val = OPT_RATEEST_BYTES},
> + {.name = "packets", .has_arg = false, .val = OPT_RATEEST_PACKETS},
> XT_GETOPT_TABLEEND,
> };
This appears to be breaking backwards compatibility.
next prev parent reply other threads:[~2011-05-24 6:46 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-23 14:39 option parsing, run 9 Jan Engelhardt
2011-05-23 14:39 ` [PATCH 01/13] libxtables: retract _NE types and use a flag instead Jan Engelhardt
2011-05-23 14:39 ` [PATCH 02/13] libipt_REDIRECT: "--to-ports" is not mandatory Jan Engelhardt
2011-05-23 14:39 ` [PATCH 03/13] libxt_quota: readd missing XTOPT_PUT request Jan Engelhardt
2011-05-23 14:39 ` [PATCH 04/13] libxt_quota: make sure uint64 is not truncated Jan Engelhardt
2011-05-23 14:39 ` [PATCH 05/13] libxtables: check for negative numbers in xtables_strtou* Jan Engelhardt
2011-05-23 14:39 ` [PATCH 06/13] libxt_rateest: streamline case display of units Jan Engelhardt
2011-05-23 14:39 ` [PATCH 07/13] doc: add some coded option examples to libxt_hashlimit Jan Engelhardt
2011-05-23 14:39 ` [PATCH 08/13] doc: make usage of libxt_rateest more obvious Jan Engelhardt
2011-05-23 14:39 ` [PATCH 09/13] doc: clarify that -p all is a special keyword only Jan Engelhardt
2011-05-23 14:39 ` [PATCH 10/13] libxt_rateest: avoid optional arguments Jan Engelhardt
2011-05-24 6:46 ` Patrick McHardy [this message]
2011-05-24 8:03 ` Jan Engelhardt
2011-05-24 8:14 ` Patrick McHardy
2011-05-24 8:51 ` Jan Engelhardt
2011-05-24 12:49 ` Patrick McHardy
2011-05-23 14:39 ` [PATCH 11/13] libxt_rateest: fix rateest save operation Jan Engelhardt
2011-05-23 14:39 ` [PATCH 12/13] libxt_rateest: use guided option parser Jan Engelhardt
2011-05-23 14:39 ` [PATCH 13/13] libxt_ipvs: restore network-byte order Jan Engelhardt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4DDB542D.5060006@trash.net \
--to=kaber@trash.net \
--cc=jengelh@medozas.de \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).