From: Pierre Rondou <prondou@gmail.com>
To: Eric Dumazet <eric.dumazet@gmail.com>
Cc: netfilter-devel@vger.kernel.org
Subject: Re: icmp_send function broken?
Date: Tue, 24 May 2011 15:42:40 +0200 [thread overview]
Message-ID: <4DDBB5D0.6000906@gmail.com> (raw)
In-Reply-To: <1306243605.3026.38.camel@edumazet-laptop>
Le 24/05/11 15:26, Eric Dumazet a écrit :
>> I'm using 2.6.32-5 kernel to developp, but the function itself didn't
>> seem to have been updated in the 2.6.38 kernel.
>>
>>
> You really should use 2.6.39 kernel for your dev...
>
It is a long-term work (started in October 2010), plus I rely on Xtables
to develop it, I used a stable kernel, as my module does not involve
kernel re-compilation.
>
>> The modification I had to apply is to re-execute the routing process on
>> the incoming paquet in order to get the ICMP packet sent:
>>
>
>
>
>> instead of the simple
>>
>> if (!rt)
>> // goto out;
>>
>> Is there an other reason why the rtable of the incoming packet was not set?
>>
> It is set by caller.
>
> check ip_rcv_finish()
>
> Also please take a look at commit 64f3b9e203bd06855
> net: ip_expire() must revalidate route
>
> [ Since I understand from a prior mail that you maybe queued an skb for
> a while for your defrag purpose ]
>
It is a packet that has just been matched by an iptables rule (my module
is simply branched on a hook), so no queue for it.
So i just should just process the routing before calling the icmp_send()
function?
--
To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
prev parent reply other threads:[~2011-05-24 13:42 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-24 13:09 icmp_send function broken? Pierre Rondou
2011-05-24 13:26 ` Eric Dumazet
2011-05-24 13:42 ` Pierre Rondou [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4DDBB5D0.6000906@gmail.com \
--to=prondou@gmail.com \
--cc=eric.dumazet@gmail.com \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).