From: Pablo Neira Ayuso <pablo@netfilter.org>
To: "Oleg A. Arkhangelsky" <sysoleg@yandex.ru>
Cc: netfilter-devel@vger.kernel.org, davem@davemloft.net
Subject: Re: [PATCH 6/7] netfilter: nf_conntrack: fix ct refcount leak in l4proto->error()
Date: Tue, 07 Jun 2011 01:17:55 +0200 [thread overview]
Message-ID: <4DED6023.6080702@netfilter.org> (raw)
In-Reply-To: <402391307326240@web153.yandex.ru>
On 06/06/11 04:10, "Oleg A. Arkhangelsky" wrote:
> Hello,
>
> 06.06.2011, 04:11, pablo@netfilter.org:
>
>> With this patch, we can also fix wrong return values (-NF_ACCEPT)
>> for special cases in ICMP[v6] that should not bump the invalid/error
>> statistic counters.
>
> Are you sure? Please, look here:
>
> http://www.spinics.net/lists/netfilter-devel/msg15520.html
We now check if we have one skb->nfct after l4proto->error(), so that
affirmation doesn't apply anymore.
next prev parent reply other threads:[~2011-06-06 23:18 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-06 0:11 [PATCH 0/7] netfilter fixes for 3.0.0-rc1 (try 2) pablo
2011-06-06 0:11 ` [PATCH 1/7] netfilter: add more values to enum ip_conntrack_info pablo
2011-06-06 0:11 ` [PATCH 2/7] ipvs: restore support for iptables SNAT pablo
2011-06-06 0:11 ` [PATCH 3/7] netfilter: ipset: Fix return code for destroy when sets are in use pablo
2011-06-06 0:11 ` [PATCH 4/7] netfilter: ipset: Use the stored first cidr value instead of '1' pablo
2011-06-06 0:11 ` [PATCH 5/7] netfilter: nf_nat: fix crash in nf_nat_csum pablo
2011-06-06 0:11 ` [PATCH 6/7] netfilter: nf_conntrack: fix ct refcount leak in l4proto->error() pablo
2011-06-06 2:10 ` "Oleg A. Arkhangelsky"
2011-06-06 23:17 ` Pablo Neira Ayuso [this message]
2011-06-06 0:11 ` [PATCH 7/7] netfilter: use unsigned variables for packet lengths in ip[6]_queue pablo
2011-06-06 0:15 ` [PATCH 0/7] netfilter fixes for 3.0.0-rc1 (try 2) David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4DED6023.6080702@netfilter.org \
--to=pablo@netfilter.org \
--cc=davem@davemloft.net \
--cc=netfilter-devel@vger.kernel.org \
--cc=sysoleg@yandex.ru \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).