From mboxrd@z Thu Jan 1 00:00:00 1970 From: Patrick McHardy Subject: Re: [PATCH] netfilter: fix looped (broad|multi)cast's MAC handling. Date: Thu, 09 Jun 2011 18:08:06 +0200 Message-ID: <4DF0EFE6.4010206@trash.net> References: <20110608153032.GA26912@Chamillionaire.breakpoint.cc> <1307626748-10992-1-git-send-email-cavallar@lri.fr> <1307626748-10992-2-git-send-email-cavallar@lri.fr> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: 7bit Cc: fw@strlen.de, netfilter-devel@vger.kernel.org, netdev@vger.kernel.org, Nicolas Cavallari To: Nicolas Cavallari Return-path: Received: from stinky.trash.net ([213.144.137.162]:41677 "EHLO stinky.trash.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751346Ab1FIQIJ (ORCPT ); Thu, 9 Jun 2011 12:08:09 -0400 In-Reply-To: <1307626748-10992-2-git-send-email-cavallar@lri.fr> Sender: netfilter-devel-owner@vger.kernel.org List-ID: On 09.06.2011 15:39, Nicolas Cavallari wrote: > By default, when broadcast or multicast packet are sent from a local > application, they are sent to the interface then looped by the kernel > to other local applications, going throught netfilter hooks in the process. > > These looped packet have their MAC header removed from the skb by the kernel > looping code. > This confuse various netfilter's netlink queue, netlink log and the > legacy ip_queue, because they try to extract a hardware > address from these packets, but extracts a part of the IP header instead. > > This patch prevent NFQUEUE, NFLOG and ip_QUEUE to include a MAC header > if there is none in the packet. Please add a Signed-off-by: line to your patch so I can apply it. Thanks!