From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Florian Westphal <fw@strlen.de>
Cc: netfilter-devel@vger.kernel.org
Subject: Re: [PATCH 0/2] conntrack: permit updating only a part of the ctmark
Date: Wed, 15 Jun 2011 14:47:37 +0200 [thread overview]
Message-ID: <4DF8A9E9.8060508@netfilter.org> (raw)
In-Reply-To: <1308140020-13487-1-git-send-email-fw@strlen.de>
On 15/06/11 14:13, Florian Westphal wrote:
> Hello Pablo,
>
> here are two patches for conntrack(8).
>
> I want to alter the upper 8 bits of the conntrack mark while keeping
> the rest intact. At the moment it is only possible to specifiy
> an absolute value, so i've extended --mark to optionally handle
> a mask argument. Its possible to either filter by mark (e.g.
> list conntracks with a particular mark bit set) or to update
> parts of the mark.
>
> The 2nd patch is not absolutely needed, but it speeds up operation
> when only a couple of conntracks are affected by the modification.
I like them both, I've applied them.
Would you send me another patch for the qa/testsuite/ to include some
test to check that --mark works with absolute value and masks?
Thank you.
next prev parent reply other threads:[~2011-06-15 12:47 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-15 12:13 [PATCH 0/2] conntrack: permit updating only a part of the ctmark Florian Westphal
2011-06-15 12:13 ` [PATCH 1/2] conntrack: add support for mark mask Florian Westphal
2011-06-15 12:13 ` [PATCH 2/2] conntrack: -U: skip sending conntrack update message if conntrack is unchanged Florian Westphal
2011-06-15 12:47 ` Pablo Neira Ayuso [this message]
2011-06-15 12:53 ` [PATCH 0/2] conntrack: permit updating only a part of the ctmark Florian Westphal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4DF8A9E9.8060508@netfilter.org \
--to=pablo@netfilter.org \
--cc=fw@strlen.de \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).