From: Patrick McHardy <kaber@trash.net>
To: Jan Engelhardt <jengelh@medozas.de>
Cc: netfilter-devel@vger.kernel.org
Subject: Re: [PATCH 1/4] netfilter: xtables: move ipt_ecn to xt_ecn
Date: Thu, 16 Jun 2011 17:34:14 +0200 [thread overview]
Message-ID: <4DFA2276.8070305@trash.net> (raw)
In-Reply-To: <alpine.LNX.2.01.1106161730540.10380@frira.zrqbmnf.qr>
On 16.06.2011 17:31, Jan Engelhardt wrote:
>
> On Thursday 2011-06-16 17:21, Patrick McHardy wrote:
>> On 09.06.2011 22:23, Jan Engelhardt wrote:
>>> --- a/net/ipv4/netfilter/Kconfig
>>> +++ b/net/ipv4/netfilter/Kconfig
>>> @@ -76,11 +76,11 @@ config IP_NF_MATCH_AH
>>> config IP_NF_MATCH_ECN
>>> tristate '"ecn" match support'
>>> depends on NETFILTER_ADVANCED
>>> - help
>>> - This option adds a `ECN' match, which allows you to match against
>>> - the IPv4 and TCP header ECN fields.
>>> -
>>> - To compile it as a module, choose M here. If unsure, say N.
>>> + select NETFILTER_XT_MATCH_ECN
>>> + ---help---
>>> + This is a backwards-compat option for the user's convenience
>>> + (e.g. when running oldconfig). It selects
>>> + CONFIG_NETFILTER_XT_MATCH_ECN.
>>>
>>
>> Did this work? I've tried myself, but it would still show the new
>> option.
>
> What do you mean? Of course it is supposed to show NETFILTER_XT_MATCH_ECN.
Well, ideally not, but fine as long as its still automatically
selected.
I'll pull your patches once the first two fixes are upstream.
next prev parent reply other threads:[~2011-06-16 15:34 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-09 20:23 xt_ecn in smaller pieces Jan Engelhardt
2011-06-09 20:23 ` [PATCH 1/4] netfilter: xtables: move ipt_ecn to xt_ecn Jan Engelhardt
2011-06-16 15:21 ` Patrick McHardy
2011-06-16 15:31 ` Jan Engelhardt
2011-06-16 15:34 ` Patrick McHardy [this message]
2011-06-16 15:43 ` Jan Engelhardt
2011-06-30 15:38 ` Jan Engelhardt
2011-06-30 16:35 ` Patrick McHardy
2011-06-09 20:23 ` [PATCH 2/4] netfilter: xtables: give xt_ecn its own name Jan Engelhardt
2011-06-09 20:23 ` [PATCH 3/4] netfilter: xtables: add an IPv6 capable version of the ECN match Jan Engelhardt
2011-06-09 20:23 ` [PATCH 4/4] netfilter: xtables: collapse conditions in xt_ecn Jan Engelhardt
-- strict thread matches above, loose matches on Subject: below --
2011-12-27 15:27 xt_ecn revisited Jan Engelhardt
2011-12-27 15:27 ` [PATCH 1/4] netfilter: xtables: move ipt_ecn to xt_ecn Jan Engelhardt
2011-12-27 18:57 xt_ecn, with descriptions Jan Engelhardt
2011-12-27 18:57 ` [PATCH 1/4] netfilter: xtables: move ipt_ecn to xt_ecn Jan Engelhardt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4DFA2276.8070305@trash.net \
--to=kaber@trash.net \
--cc=jengelh@medozas.de \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).