netfilter-devel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Patrick McHardy <kaber@trash.net>
To: Jozsef Kadlecsik <kadlec@blackhole.kfki.hu>
Cc: netfilter-devel@vger.kernel.org, Pablo Neira Ayuso <pablo@netfilter.org>
Subject: Re: [PATCH 03/15] netfilter: ipset: Options and flags support added to the kernel API
Date: Thu, 16 Jun 2011 18:46:54 +0200	[thread overview]
Message-ID: <4DFA337E.8030407@trash.net> (raw)
In-Reply-To: <1307465780-28980-4-git-send-email-kadlec@blackhole.kfki.hu>

On 07.06.2011 18:56, Jozsef Kadlecsik wrote:
> The support makes possible to specify the timeout value for
> the SET target and a flag to reset the timeout for already existing
> entries.

Applied.

> --- a/include/linux/netfilter/xt_set.h
> +++ b/include/linux/netfilter/xt_set.h
> @@ -44,13 +44,22 @@ struct xt_set_info {
>  };
>  
>  /* match and target infos */
> -struct xt_set_info_match {
> +struct xt_set_info_match_v1 {
>  	struct xt_set_info match_set;
>  };
>  
> -struct xt_set_info_target {
> +struct xt_set_info_target_v1 {
>  	struct xt_set_info add_set;
>  	struct xt_set_info del_set;
>  };
>  

But we shouldn't rename existing structures that are already
exposed to userspace.

  parent reply	other threads:[~2011-06-16 16:46 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-06-07 16:56 [PATCH 00/15] ipset patches against nf-next-2.6, next try Jozsef Kadlecsik
2011-06-07 16:56 ` [PATCH 01/15] netfilter: ipset: Timeout can be modified for already added elements Jozsef Kadlecsik
2011-06-07 16:56   ` [PATCH 02/15] netfilter: ipset: Whitespace fixes: some space before tab slipped in Jozsef Kadlecsik
2011-06-07 16:56     ` [PATCH 03/15] netfilter: ipset: Options and flags support added to the kernel API Jozsef Kadlecsik
2011-06-07 16:56       ` [PATCH 04/15] netfilter: ipset: Support listing setnames and headers too Jozsef Kadlecsik
2011-06-07 16:56         ` [PATCH 05/15] netfilter: ipset: Fix adding ranges to hash types Jozsef Kadlecsik
2011-06-07 16:56           ` [PATCH 06/15] netfilter: ipset: Set type support with multiple revisions added Jozsef Kadlecsik
2011-06-07 16:56             ` [PATCH 07/15] netfilter: ipset: Support range for IPv4 at adding/deleting elements for hash:*net* types Jozsef Kadlecsik
2011-06-07 16:56               ` [PATCH 08/15] netfilter: ipset: Adding ranges to hash types with timeout could still fail, fixed Jozsef Kadlecsik
2011-06-07 16:56                 ` [PATCH 09/15] netfilter: ipset: Take into account cidr value for the from address when creating the set Jozsef Kadlecsik
2011-06-07 16:56                   ` [PATCH 10/15] netfilter: ipset: Use unified from/to address masking and check the usage Jozsef Kadlecsik
2011-06-07 16:56                     ` [PATCH 11/15] netfilter: ipset: Add xt_action_param to the variant level kadt functions, ipset API change Jozsef Kadlecsik
2011-06-07 16:56                       ` [PATCH 12/15] netfilter: ipset: Fix return code for destroy when sets are in use Jozsef Kadlecsik
2011-06-07 16:56                         ` [PATCH 13/15] netfilter: ipset: Use the stored first cidr value instead of '1' Jozsef Kadlecsik
2011-06-07 16:56                           ` [PATCH 14/15] netfilter: ipset: hash:net,iface type introduced Jozsef Kadlecsik
2011-06-07 16:56                             ` [PATCH 15/15] netfilter: ipset: Whitespace and coding fixes detected by checkpatch.pl Jozsef Kadlecsik
2011-06-16 17:01                               ` Patrick McHardy
2011-06-16 17:01                             ` [PATCH 14/15] netfilter: ipset: hash:net,iface type introduced Patrick McHardy
2011-06-16 16:58                           ` [PATCH 13/15] netfilter: ipset: Use the stored first cidr value instead of '1' Patrick McHardy
2011-06-16 16:58                         ` [PATCH 12/15] netfilter: ipset: Fix return code for destroy when sets are in use Patrick McHardy
2011-06-16 16:57                       ` [PATCH 11/15] netfilter: ipset: Add xt_action_param to the variant level kadt functions, ipset API change Patrick McHardy
2011-06-16 16:56                     ` [PATCH 10/15] netfilter: ipset: Use unified from/to address masking and check the usage Patrick McHardy
2011-06-16 16:55                   ` [PATCH 09/15] netfilter: ipset: Take into account cidr value for the from address when creating the set Patrick McHardy
2011-06-16 16:54                 ` [PATCH 08/15] netfilter: ipset: Adding ranges to hash types with timeout could still fail, fixed Patrick McHardy
2011-06-16 16:53               ` [PATCH 07/15] netfilter: ipset: Support range for IPv4 at adding/deleting elements for hash:*net* types Patrick McHardy
2011-06-16 16:52             ` [PATCH 06/15] netfilter: ipset: Set type support with multiple revisions added Patrick McHardy
2011-06-16 16:51           ` [PATCH 05/15] netfilter: ipset: Fix adding ranges to hash types Patrick McHardy
2011-06-16 16:49         ` [PATCH 04/15] netfilter: ipset: Support listing setnames and headers too Patrick McHardy
2011-06-16 16:46       ` Patrick McHardy [this message]
2011-06-16 16:42     ` [PATCH 02/15] netfilter: ipset: Whitespace fixes: some space before tab slipped in Patrick McHardy
2011-06-16 16:41   ` [PATCH 01/15] netfilter: ipset: Timeout can be modified for already added elements Patrick McHardy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4DFA337E.8030407@trash.net \
    --to=kaber@trash.net \
    --cc=kadlec@blackhole.kfki.hu \
    --cc=netfilter-devel@vger.kernel.org \
    --cc=pablo@netfilter.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).