From mboxrd@z Thu Jan 1 00:00:00 1970 From: Patrick McHardy Subject: Re: [PATCH 1/4] netfilter: xtables: move ipt_ecn to xt_ecn Date: Thu, 30 Jun 2011 18:35:32 +0200 Message-ID: <4E0CA5D4.3090003@trash.net> References: <1307651037-20520-1-git-send-email-jengelh@medozas.de> <1307651037-20520-2-git-send-email-jengelh@medozas.de> <4DFA1F60.7080704@trash.net> <4DFA2276.8070305@trash.net> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: netfilter-devel@vger.kernel.org To: Jan Engelhardt Return-path: Received: from stinky.trash.net ([213.144.137.162]:48420 "EHLO stinky.trash.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752859Ab1F3Qfg (ORCPT ); Thu, 30 Jun 2011 12:35:36 -0400 In-Reply-To: Sender: netfilter-devel-owner@vger.kernel.org List-ID: Am 30.06.2011 17:38, schrieb Jan Engelhardt: > On Thursday 2011-06-16 17:43, Jan Engelhardt wrote: > >> On Thursday 2011-06-16 17:34, Patrick McHardy wrote: >> >>> On 16.06.2011 17:31, Jan Engelhardt wrote: >>>> >>>> On Thursday 2011-06-16 17:21, Patrick McHardy wrote: >>>>> On 09.06.2011 22:23, Jan Engelhardt wrote: >>>>>> --- a/net/ipv4/netfilter/Kconfig >>>>>> +++ b/net/ipv4/netfilter/Kconfig >>>>>> @@ -76,11 +76,11 @@ config IP_NF_MATCH_AH >>>>>> config IP_NF_MATCH_ECN >>>>>> tristate '"ecn" match support' >>>>>> depends on NETFILTER_ADVANCED >>>>>> - help >>>>>> - This option adds a `ECN' match, which allows you to match against >>>>>> - the IPv4 and TCP header ECN fields. >>>>>> - >>>>>> - To compile it as a module, choose M here. If unsure, say N. >>>>>> + select NETFILTER_XT_MATCH_ECN >>>>>> + ---help--- >>>>>> + This is a backwards-compat option for the user's convenience >>>>>> + (e.g. when running oldconfig). It selects >>>>>> + CONFIG_NETFILTER_XT_MATCH_ECN. >>>>>> >>>>> >>>>> Did this work? I've tried myself, but it would still show the new >>>>> option. >>>> >>>> What do you mean? Of course it is supposed to show NETFILTER_XT_MATCH_ECN. >>> >>> Well, ideally not, but fine as long as its still automatically >>> selected. >>> >>> I'll pull your patches once the first two fixes are upstream. >> >> We are doing the same thing with the old options for nfmark/ctmark >> (cf. Documentation/feature-removal-schedule.txt) so I guess that was ok. >> The old options are supposed to be gone in a few releases anyway. > > ping? > It hasn't been merged with net-next yet. Don't worry, I'll take care of that once Dave has merged it.