* [PATCH conntrack] conntrack: add missing break when parsing --id/--secmark options
@ 2011-06-15 21:39 Florian Westphal
2011-07-08 11:31 ` Pablo Neira Ayuso
0 siblings, 1 reply; 2+ messages in thread
From: Florian Westphal @ 2011-06-15 21:39 UTC (permalink / raw)
To: netfilter-devel; +Cc: Florian Westphal
commit 147ed522f52a62ab0d854ddc443d27d97dbf6cdf
(conntrack: add support for mark mask) failed to add a break
after secmark/id option parsing.
Results in '-m 42 -c 1' to search for mark 1 instead of 42.
Signed-off-by: Florian Westphal <fw@strlen.de>
---
Sorry about this; i did not see it until now...
diff --git a/src/conntrack.c b/src/conntrack.c
index 3e1cb11..8eae554 100644
--- a/src/conntrack.c
+++ b/src/conntrack.c
@@ -1566,6 +1566,7 @@ int main(int argc, char *argv[])
nfct_set_attr_u32(tmpl.ct,
opt2attr[c],
strtoul(optarg, NULL, 0));
+ break;
case 'm':
options |= opt2type[c];
parse_u32_mask(optarg, &tmpl.mark);
--
1.7.3.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH conntrack] conntrack: add missing break when parsing --id/--secmark options
2011-06-15 21:39 [PATCH conntrack] conntrack: add missing break when parsing --id/--secmark options Florian Westphal
@ 2011-07-08 11:31 ` Pablo Neira Ayuso
0 siblings, 0 replies; 2+ messages in thread
From: Pablo Neira Ayuso @ 2011-07-08 11:31 UTC (permalink / raw)
To: Florian Westphal; +Cc: netfilter-devel
On 15/06/11 23:39, Florian Westphal wrote:
> commit 147ed522f52a62ab0d854ddc443d27d97dbf6cdf
> (conntrack: add support for mark mask) failed to add a break
> after secmark/id option parsing.
>
> Results in '-m 42 -c 1' to search for mark 1 instead of 42.
Applied, thanks.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2011-07-08 11:31 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-06-15 21:39 [PATCH conntrack] conntrack: add missing break when parsing --id/--secmark options Florian Westphal
2011-07-08 11:31 ` Pablo Neira Ayuso
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).