From: Patrick McHardy <kaber@trash.net>
To: Florian Westphal <fw@strlen.de>
Cc: netfilter-devel@vger.kernel.org, Julian Anastasov <ja@ssi.bg>,
Eric Dumazet <eric.dumazet@gmail.com>
Subject: Re: [PATCH] netfilter: nf_queue: reject NF_STOLEN verdicts from userspace
Date: Tue, 30 Aug 2011 15:02:02 +0200 [thread overview]
Message-ID: <4E5CDF4A.3090206@trash.net> (raw)
In-Reply-To: <1313181292-8683-1-git-send-email-fw@strlen.de>
On 12.08.2011 22:34, Florian Westphal wrote:
> A userspace listener may send (bogus) NF_STOLEN verdict, which causes skb leak.
>
> This problem was previously fixed via
> 64507fdbc29c3a622180378210ecea8659b14e40 (netfilter:
> nf_queue: fix NF_STOLEN skb leak) but this had to be reverted because
> NF_STOLEN can also be returned by a netfilter hook when iterating the
> rules in nf_reinject.
>
> Reject userspace NF_STOLEN verdict, as suggested by Michał Mirosław.
>
> This is complementary to commit fad54440438a7c231a6ae347738423cbabc936d9
> (netfilter: avoid double free in nf_reinject).
>
> Cc: Julian Anastasov <ja@ssi.bg>
> Cc: Eric Dumazet <eric.dumazet@gmail.com>
> Signed-off-by: Florian Westphal <fw@strlen.de>
Applied, thanks Florian.
--
To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
prev parent reply other threads:[~2011-08-30 13:02 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-12 20:34 [PATCH] netfilter: nf_queue: reject NF_STOLEN verdicts from userspace Florian Westphal
2011-08-30 13:02 ` Patrick McHardy [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E5CDF4A.3090206@trash.net \
--to=kaber@trash.net \
--cc=eric.dumazet@gmail.com \
--cc=fw@strlen.de \
--cc=ja@ssi.bg \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).