From: Patrick McHardy <kaber@trash.net>
To: Pablo Neira Ayuso <pablo@netfilter.org>
Cc: Jan Engelhardt <jengelh@medozas.de>,
"Anthony G. Basile" <basile@opensource.dyc.edu>,
davem@davemloft.net, blueness@gentoo.org, gurligebis@gentoo.org,
base-system@gentoo.org, kernel@gentoo.org, toolchain@gentoo.org,
mchehab@redhat.com, hverkuil@xs4all.nl,
laurent.pinchart@ideasonboard.com, arnd@arndb.de,
eparis@redhat.com, netfilter-devel@vger.kernel.org
Subject: Re: [PATCH] netfilter: install nf_nat.h and related headers to INSTALL_HDR_PATH
Date: Wed, 07 Sep 2011 16:50:43 +0200 [thread overview]
Message-ID: <4E6784C3.70906@trash.net> (raw)
In-Reply-To: <20110907093104.GA9078@1984>
On 07.09.2011 11:31, Pablo Neira Ayuso wrote:
> On Tue, Sep 06, 2011 at 08:11:30PM +0200, Jan Engelhardt wrote:
>>
>> On Tuesday 2011-09-06 18:44, Anthony G. Basile wrote:
>>>>
>>>> Could anyone clarify why miniupnpd (or any other application) require
>>>> this?
>>>>
>>>> Those headers contain structure layouts that may change along time
>>>> without further notice, thus breaking backward compatibility.
>>>
>>> It makes use of
>>>
>>> union nf_conntrack_man_proto
>>> struct nf_nat_range
>>> struct nf_nat_multi_range_compat
>>
>> miniupnpd is fiddling with the binary representation. Yes, classic
>> case of "all the xt headers are exported, just DNAT/SNAT's structs are not".
>>
>> Did miniupnpd consider using the text-based interface?
>
> The iptables NAT targets are using this binary representation, so we
> should export those definitions. We gain nothing from keeping them
> defined privately.
>
Agreed.
prev parent reply other threads:[~2011-09-07 16:46 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-03 18:49 [PATCH] netfilter: install nf_nat.h and related headers to INSTALL_HDR_PATH Anthony G. Basile
2011-09-03 19:41 ` Jan Engelhardt
2011-09-05 17:48 ` Pablo Neira Ayuso
2011-09-06 16:44 ` Anthony G. Basile
2011-09-06 18:05 ` Pablo Neira Ayuso
2011-09-06 18:11 ` Jan Engelhardt
2011-09-07 9:31 ` Pablo Neira Ayuso
2011-09-07 14:50 ` Patrick McHardy [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E6784C3.70906@trash.net \
--to=kaber@trash.net \
--cc=arnd@arndb.de \
--cc=base-system@gentoo.org \
--cc=basile@opensource.dyc.edu \
--cc=blueness@gentoo.org \
--cc=davem@davemloft.net \
--cc=eparis@redhat.com \
--cc=gurligebis@gentoo.org \
--cc=hverkuil@xs4all.nl \
--cc=jengelh@medozas.de \
--cc=kernel@gentoo.org \
--cc=laurent.pinchart@ideasonboard.com \
--cc=mchehab@redhat.com \
--cc=netfilter-devel@vger.kernel.org \
--cc=pablo@netfilter.org \
--cc=toolchain@gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).