From: Hiroshi KIHIRA <hiro@dump-Storage.net>
To: Pablo Neira Ayuso <pablo@netfilter.org>
Cc: netfilter-devel@vger.kernel.org
Subject: Re: [PATCH RFC] iptables-restore: new option to change the commit timing
Date: Mon, 12 Sep 2011 20:52:59 +0900 [thread overview]
Message-ID: <4E6DF29B.3020901@dump-Storage.net> (raw)
In-Reply-To: <20110912092807.GB2194@1984>
(11/09/12 18:28), Pablo Neira Ayuso wrote:
> I think people should call iptables-restore -T to test the rule-set
> before, at least the first time the have saved the rule-set, to make
> sure that they don't run into inconsistencies.
>
> Applying the rule-set partially for one table may also result in
> inconsistencies, so I still don't see what we gain from allowing this.
Yes, The inconsistencies from syntax error can be avoided by -t/--test
option.
But, if the iptables-restore used in a rule generation script and it
fails, inconsistencies will occur. So, I think that the iptables-restore
should avoid the inconsistencies even if the wrong rule-set was inputted
at the real run.
Also, I think that the iptables-restore needs rollback capability for the
situation of iptc_commit failure.
next prev parent reply other threads:[~2011-09-12 11:53 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-08 13:28 [PATCH RFC] iptables-restore: new option to change the commit timing Hiroshi KIHIRA
2011-09-08 15:00 ` Jan Engelhardt
2011-09-08 15:06 ` Eric Dumazet
2011-09-08 15:22 ` Jan Engelhardt
2011-09-09 5:26 ` Maciej Żenczykowski
2011-09-10 17:27 ` Hiroshi KIHIRA
2011-09-12 9:28 ` Pablo Neira Ayuso
2011-09-12 11:52 ` Hiroshi KIHIRA [this message]
2011-09-12 18:19 ` Pablo Neira Ayuso
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E6DF29B.3020901@dump-Storage.net \
--to=hiro@dump-storage.net \
--cc=netfilter-devel@vger.kernel.org \
--cc=pablo@netfilter.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).