[ANNOUNCE] ipset 6.9.1 released

[ANNOUNCE] ipset 6.9.1 released

[Jozsef Kadlecsik]

Hi,

I'm happy to announce ipset 6.9.1. It contains two important bugfixes: if 
you use ipset on a hardware with tight memory usage, please upgrade.

Kernel part changes:
 - Fix compiling ipset as external kernel modules (broken v6.9)
 - Complete Kconfig with hash:net,iface type (standalone package)
 - rtnetlink: Compute and store minimum ifinfo dump size (Greg Rose)
 - Remove redundant linux/version.h includes from net/ (Jesper Juhl)
 - ipset: use NFPROTO_ constants (Jan Engelhardt)
 - netfilter: ipset: expose userspace-relevant parts in ip_set.h
   (Jan Engelhardt)
 - netfilter: ipset: avoid use of kernel-only types (Jan Engelhardt)
 - netfilter: Remove unnecessary OOM logging messages (Joe Perches)
 - Dumping error triggered removing references twice and lead to kernel 
   BUG
 - Autoload set type modules safely

Userspace changes:
 - build: move ipset_errcode into library (Jan Engelhardt)
 - build: abort autogen on subcommand failure (Jan Engelhardt)
 - ipset: use NFPROTO_ constants (Jan Engelhardt)
 - Propagate "expose userspace-relevant parts in ip_set.h" to ipset source

You can download the source code of ipset from:
        http://ipset.netfilter.org
        ftp://ftp.netfilter.org/pub/ipset/
        git://git.netfilter.org/ipset.git

Best regards,
Jozsef
-
E-mail  : kadlec@blackhole.kfki.hu, kadlec@mail.kfki.hu
PGP key : http://www.kfki.hu/~kadlec/pgp_public_key.txt
Address : KFKI Research Institute for Particle and Nuclear Physics
          H-1525 Budapest 114, POB. 49, Hungary

Re: [ANNOUNCE] ipset 6.9.1 released

[Mr Dash Four]

Jozsef Kadlecsik wrote:
> I'm happy to announce ipset 6.9.1. It contains two important bugfixes: if 
> you use ipset on a hardware with tight memory usage, please upgrade.
>   
I am trying to compile this source (kernel modules only) against the 
latest fedora-released kernel - 2.6.40 (a.k.a. 3.0.1), but get the 
following errors:

net/netfilter/ipset/ip_set_core.c:244:5: warning: "LINUX_VERSION_CODE" 
is not defined
net/netfilter/ipset/ip_set_core.c:244:26: warning: "KERNEL_VERSION" is 
not defined
net/netfilter/ipset/ip_set_core.c:244:40: error: missing binary operator 
before token "("
net/netfilter/ipset/ip_set_core.c:1175:5: warning: "LINUX_VERSION_CODE" 
is not defined
net/netfilter/ipset/ip_set_core.c:1175:26: warning: "KERNEL_VERSION" is 
not defined
net/netfilter/ipset/ip_set_core.c:1175:40: error: missing binary 
operator before token "("
net/netfilter/ipset/ip_set_core.c: In function 'ip_set_dump':
net/netfilter/ipset/ip_set_core.c:1178: error: too many arguments to 
function 'netlink_dump_start'
make[3]: *** [net/netfilter/ipset/ip_set_core.o] Error 1
make[3]: *** Waiting for unfinished jobs....
make[2]: *** [net/netfilter/ipset] Error 2
make[1]: *** [net/netfilter] Error 2
make: *** [net] Error 2
make: *** Waiting for unfinished jobs....


Am I missing something?

Re: [ANNOUNCE] ipset 6.9.1 released

[Jozsef Kadlecsik]

On Thu, 15 Sep 2011, Mr Dash Four wrote:

> Jozsef Kadlecsik wrote:
> > I'm happy to announce ipset 6.9.1. It contains two important bugfixes: if
> > you use ipset on a hardware with tight memory usage, please upgrade.
> >   
> I am trying to compile this source (kernel modules only) against the latest
> fedora-released kernel - 2.6.40 (a.k.a. 3.0.1), but get the following errors:
> 
> net/netfilter/ipset/ip_set_core.c:244:5: warning: "LINUX_VERSION_CODE" is not
> defined
> net/netfilter/ipset/ip_set_core.c:244:26: warning: "KERNEL_VERSION" is not
> defined
> net/netfilter/ipset/ip_set_core.c:244:40: error: missing binary operator
> before token "("
> net/netfilter/ipset/ip_set_core.c:1175:5: warning: "LINUX_VERSION_CODE" is not
> defined
> net/netfilter/ipset/ip_set_core.c:1175:26: warning: "KERNEL_VERSION" is not
> defined
> net/netfilter/ipset/ip_set_core.c:1175:40: error: missing binary operator
> before token "("
> net/netfilter/ipset/ip_set_core.c: In function 'ip_set_dump':
> net/netfilter/ipset/ip_set_core.c:1178: error: too many arguments to function
> 'netlink_dump_start'
> make[3]: *** [net/netfilter/ipset/ip_set_core.o] Error 1
> make[3]: *** Waiting for unfinished jobs....
> make[2]: *** [net/netfilter/ipset] Error 2
> make[1]: *** [net/netfilter] Error 2
> make: *** [net] Error 2
> make: *** Waiting for unfinished jobs....
> 
> Am I missing something?

I suppose you are trying to compile the kernel part of the package 
directly. What should be done is as follows:

ipset-6.9.1$ ./autogen.sh
ipset-6.9.1$ ./configure --with-kbuild=/fedora/released/kernel/tree
ipset-6.9.1$ make modules
ipset-6.9.1$ make modules_install

Or your kernel tree is not prepared for building external modules:
you should run at least "make modules_prepare" in 
/fedora/released/kernel/tree.

Best regards,
Jozsef
-
E-mail  : kadlec@blackhole.kfki.hu, kadlec@mail.kfki.hu
PGP key : http://www.kfki.hu/~kadlec/pgp_public_key.txt
Address : KFKI Research Institute for Particle and Nuclear Physics
          H-1525 Budapest 114, POB. 49, Hungary

Re: [ANNOUNCE] ipset 6.9.1 released

[Jan Engelhardt]

On Thursday 2011-09-15 08:53, Jozsef Kadlecsik wrote:
>
>I suppose you are trying to compile the kernel part of the package 
>directly. What should be done is as follows:
>
>ipset-6.9.1$ ./autogen.sh
>ipset-6.9.1$ ./configure --with-kbuild=/fedora/released/kernel/tree
>ipset-6.9.1$ make modules
>ipset-6.9.1$ make modules_install
>
>Or your kernel tree is not prepared for building external modules:
>you should run at least "make modules_prepare" in 
>/fedora/released/kernel/tree.

modules_prepare may not be enough. When you see

	WARNING: Symbol version dump 
	/home/jengelh/code/linux-hist/obj39/Module.symvers is missing; 
	modules	will have no dependencies and modversions.

building the kernel base image is mandatory for creation of 
Modules.symvers.

Re: [ANNOUNCE] ipset 6.9.1 released

[Mr Dash Four]

> I suppose you are trying to compile the kernel part of the package 
> directly. What should be done is as follows:
>   
No, actually, I am building ipset as part of the kernel built - I patch 
the sources (i.e. "copy" most of the files in kernel/include and 
kernel/net to the kernel tree) and then (trying to) build the kernel 
itself in the same way as I did with 6.8. The difference this time is 
that I've got the above errors. These occur during the kernel built - 
sorry, I should have made this clear.

Re: [ANNOUNCE] ipset 6.9.1 released

[Jozsef Kadlecsik]

On Thu, 15 Sep 2011, Mr Dash Four wrote:

> > I suppose you are trying to compile the kernel part of the package directly.
> > What should be done is as follows:
> >   
> No, actually, I am building ipset as part of the kernel built - I patch the
> sources (i.e. "copy" most of the files in kernel/include and kernel/net to the
> kernel tree) and then (trying to) build the kernel itself in the same way as I
> did with 6.8. The difference this time is that I've got the above errors.
> These occur during the kernel built - sorry, I should have made this clear.

The source tree is not supposed to be copied to the kernel tree.

At the moment you have to hand-edit ip_set_core.c: delete
the #ifdef .. #endif part around

#ifdef IPSET_EXTERNAL_MODULE
#include <linux/version.h>
#endif

In the next release I'll invert the logic of the condition and then it'll 
work even when copied into the kernel tree.

Best regards,
Jozsef
-
E-mail  : kadlec@blackhole.kfki.hu, kadlec@mail.kfki.hu
PGP key : http://www.kfki.hu/~kadlec/pgp_public_key.txt
Address : KFKI Research Institute for Particle and Nuclear Physics
          H-1525 Budapest 114, POB. 49, Hungary

Re: [ANNOUNCE] ipset 6.9.1 released

[Mr Dash Four]

> The source tree is not supposed to be copied to the kernel tree.
>   
Right, I take it this is something new introduced with 6.9.1 as with 6.8 
I had no such problems.

> At the moment you have to hand-edit ip_set_core.c: delete
> the #ifdef .. #endif part around
>
> #ifdef IPSET_EXTERNAL_MODULE
> #include <linux/version.h>
> #endif
>
> In the next release I'll invert the logic of the condition and then it'll 
> work even when copied into the kernel tree.
>   
I'll do that, thanks Jozsef!