From: "Anthony G. Basile" <basile@opensource.dyc.edu>
To: Jan Engelhardt <jengelh@medozas.de>
Cc: davem@davemloft.net, kaber@trash.net, blueness@gentoo.org,
gurligebis@gentoo.org, base-system@gentoo.org, kernel@gentoo.org,
toolchain@gentoo.org, mchehab@redhat.com, hverkuil@xs4all.nl,
laurent.pinchart@ideasonboard.com, arnd@arndb.de,
eparis@redhat.com, netfilter-devel@vger.kernel.org
Subject: Re: [PATCH] netfilter: export sanitized nf_nat.h to INSTALL_HDR_PATH
Date: Sun, 02 Oct 2011 09:01:18 -0400 [thread overview]
Message-ID: <4E88609E.2030404@opensource.dyc.edu> (raw)
In-Reply-To: <alpine.LNX.2.01.1110021451540.12367@frira.zrqbmnf.qr>
On 10/02/2011 08:53 AM, Jan Engelhardt wrote:
> On Saturday 2011-10-01 19:54, Anthony G. Basile wrote:
>
>> As an appendix to this patch, let me add a couple of points:
>>
>> 1) In the union,
>>
>>> +union nf_conntrack_man_proto {
>>> + __be16 all;
>>> + __be16 port;
>>> + __be16 icmp_idnt;
>>> + __be16 gre_key;
>>> +};
>>
>> I named the one member icmp_idnt to avoid a name collision with "#define
>> icmp_id ..." in <netinet/ip_icmp.h>. This causes problems in both
>> iptables and miniupnpd.
>
> Wow that's a horrible thing to do of ip_icmp.h. Such #defines should die
> because their scope is way too broad.
I know. I hate it too, and it was not easy to catch. But how else do
we get around it? We could do an undef, but that's just as ugly.
--
Anthony G. Basile, Ph. D.
Chair of Information Technology
D'Youville College
Buffalo, NY 14201
(716) 829-8197
next prev parent reply other threads:[~2011-10-02 13:01 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-01 17:51 [PATCH] netfilter: export sanitized nf_nat.h to INSTALL_HDR_PATH Anthony G. Basile
2011-10-01 17:54 ` Anthony G. Basile
2011-10-02 12:53 ` Jan Engelhardt
2011-10-02 13:01 ` Anthony G. Basile [this message]
2011-10-11 1:40 ` Pablo Neira Ayuso
2011-10-11 21:34 ` Anthony G. Basile
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E88609E.2030404@opensource.dyc.edu \
--to=basile@opensource.dyc.edu \
--cc=arnd@arndb.de \
--cc=base-system@gentoo.org \
--cc=blueness@gentoo.org \
--cc=davem@davemloft.net \
--cc=eparis@redhat.com \
--cc=gurligebis@gentoo.org \
--cc=hverkuil@xs4all.nl \
--cc=jengelh@medozas.de \
--cc=kaber@trash.net \
--cc=kernel@gentoo.org \
--cc=laurent.pinchart@ideasonboard.com \
--cc=mchehab@redhat.com \
--cc=netfilter-devel@vger.kernel.org \
--cc=toolchain@gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).