From: marty <martinbarrowcliff@gmail.com>
To: netfilter-devel@vger.kernel.org
Subject: Re: Ulogd - mysql addresses are in network-byte order
Date: Mon, 02 Jan 2012 15:02:21 -0500 [thread overview]
Message-ID: <4F020D4D.5060102@gmail.com> (raw)
In-Reply-To: <20120102180811.GA26533@1984>
On 01/02/2012 01:08 PM, Pablo Neira Ayuso wrote:
> On Mon, Jan 02, 2012 at 12:03:46AM -0500, marty wrote:
>>
>> Here, for your review is a patch to
>> address the issue that I reported.
>>
>> --- orig.ulogd_raw2packet_BASE.c 2011-12-08 11:55:09.000000000 -0500
>> +++ ulogd_raw2packet_BASE.c 2012-01-01 23:40:14.000000000 -0500
>> @@ -717,8 +717,8 @@
>> return ULOGD_IRET_OK;
>> len -= iph->ihl * 4;
>>
>> - okey_set_u32(&ret[KEY_IP_SADDR], iph->saddr);
>> - okey_set_u32(&ret[KEY_IP_DADDR], iph->daddr);
>> + okey_set_u32(&ret[KEY_IP_SADDR], ntohl(iph->saddr));
>> + okey_set_u32(&ret[KEY_IP_DADDR], ntohl(iph->daddr));
>> okey_set_u8(&ret[KEY_IP_PROTOCOL], iph->protocol);
>> okey_set_u8(&ret[KEY_IP_TOS], iph->tos);
>> okey_set_u8(&ret[KEY_IP_TTL], iph->ttl);
>
> Many other plugins rely on the address in network byte order.
>
> Can you fix this in the mysql plugin by adding some configurable
> option?
Seems like I already offered config options previously, no...
And as I recall I gave fair warning, which you ignored.
Simply put the host arch should determine IP format. That is a given.
That is easily changed to network format where/when required.
Personally I would write the BASE code as I have,
and let the option for network byte order be available
as a config option, as I suggested from the start.
The mysql-plugin does not have the keys available directly.
It pretty much passes data blindly.
I am hesitant to change this because it works nice.
> more suggestions for your next patches, please:
>
> * include short description before the patch.
> * they have to apply with patch -p1< file.patch
Agreed, I should submit patches with more info.
> you can generate this with git diff HEAD (there are more advanced ways
> to do this in git though)
Yes, I can do lots of things; even stand on my head.
But I fixed the issue as requested and if that is not sufficient I am
terribly sorry, but I am a 60+ yr old man with a big schedule.
The code works fine for my purposes and you are not inspiring me.
Marty B.
next prev parent reply other threads:[~2012-01-02 20:02 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-02 5:03 Ulogd - mysql addresses are in network-byte order marty
2012-01-02 18:08 ` Pablo Neira Ayuso
2012-01-02 20:02 ` marty [this message]
-- strict thread matches above, loose matches on Subject: below --
2011-12-31 16:36 marty
2011-12-31 17:27 ` Pablo Neira Ayuso
2011-12-31 18:28 ` marty
2012-01-01 15:55 ` Pablo Neira Ayuso
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F020D4D.5060102@gmail.com \
--to=martinbarrowcliff@gmail.com \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).