From: Richard Weinberger <richard@nod.at>
To: Bart De Schuymer <bdschuym@pandora.be>
Cc: Stephen Hemminger <shemminger@vyatta.com>,
davem@davemloft.net, bridge@lists.linux-foundation.org,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
netfilter-devel@vger.kernel.org
Subject: Re: [PATCH] netfilter: Fix br_nf_pre_routing() in conjunction with bridge-nf-call-ip(6)tables=0
Date: Tue, 03 Jan 2012 21:29:01 +0100 [thread overview]
Message-ID: <4F03650D.8050200@nod.at> (raw)
In-Reply-To: <4F0361D7.3000602@pandora.be>
[-- Attachment #1: Type: text/plain, Size: 809 bytes --]
Am 03.01.2012 21:15, schrieb Bart De Schuymer:
> The documentation is probably not explicit enough, but I would keep the
> behavior as it is now. Setting bridge-nf-call-iptables to 0 makes
> iptables behave as if bridge-netfilter was not enabled at compilation.
> Anyway, your patch is almost certainly flawed since the fact that
> skb->nf_bridge can be NULL is used as part of the logic in
> br_netfilter.c: it indicates that bridge-nf-call-iptables was 0 when the
> packet was first processed by bridge-netfilter and should therefore not
> be given to iptables in any other netfilter hook.
Thanks for the explanation!
Wouldn't it make sense to check for bridge-nf-call-iptables in xt_physdev?
So that the user gets warned that his iptables rule will never match...
Thanks,
//richard
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 490 bytes --]
next prev parent reply other threads:[~2012-01-03 20:29 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-03 1:29 xt_physdev has no effect if net.bridge.bridge-nf-call-iptables=0 Richard Weinberger
2012-01-03 13:26 ` Richard Weinberger
2012-01-03 13:26 ` [PATCH] netfilter: Fix br_nf_pre_routing() in conjunction with bridge-nf-call-ip(6)tables=0 Richard Weinberger
2012-01-03 16:15 ` Stephen Hemminger
2012-01-03 17:42 ` Richard Weinberger
2012-01-03 20:15 ` Bart De Schuymer
2012-01-03 20:29 ` Richard Weinberger [this message]
2012-01-04 17:55 ` Bart De Schuymer
2012-01-04 23:13 ` Richard Weinberger
2012-01-05 19:50 ` Bart De Schuymer
2012-01-05 19:54 ` Richard Weinberger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F03650D.8050200@nod.at \
--to=richard@nod.at \
--cc=bdschuym@pandora.be \
--cc=bridge@lists.linux-foundation.org \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=shemminger@vyatta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).