netfilter-devel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Bart De Schuymer <bdschuym@pandora.be>
To: joe@clnt.de
Cc: netfilter-devel@vger.kernel.org
Subject: Re: alignment problem with ebt_among on ppc
Date: Thu, 09 Feb 2012 20:22:54 +0100	[thread overview]
Message-ID: <4F341D0E.3020209@pandora.be> (raw)
In-Reply-To: <Pine.LNX.4.64.1202030819151.17732@brian.int.clnt.de>

Op 3/02/2012 8:21, joe@clnt.de schreef:
> What I've seen is that ebt_among extension of ebtables uses
> __alignof__(_xt_align) while the corresponding kernel module uses
> __alignof__(ebt_replace) to determin the alignment in EBT_ALIGN().
>
> These are the results of these values on different platforms:
>
> x86 x86_64 ppc
> __alignof__(_xt_align) 4 8 8
> __alignof__(ebt_replace) 4 8 4
>
> So I assume here we can see why ebtales fails to add rules which use the
> among extension.
>
> I'm using kernel 2.6.33 and ebtables 2.0.10-4
>
> Is this a known issue or are there any suggestions how to circumvent this
> problem?
> Thankyou very much.

The userspace alignment was changed to _xt_align to fix an alignment 
issue on a userspace32-kernel64 system (I think it was for an ARM 
device). So userspace must be right. The kernel alignment macro needs to 
change so it also uses _xt_align instead of ebt_replace. The userspace 
changes date back from June 29, 2009.
Can you do these changes and provide a patch?

cheers,
Bart


-- 
Bart De Schuymer
www.artinalgorithms.be

  reply	other threads:[~2012-02-09 19:23 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-02-03  7:21 alignment problem with ebt_among on ppc joe
2012-02-09 19:22 ` Bart De Schuymer [this message]
2012-02-10 12:17   ` Joerg Willmann
2012-02-10 17:39     ` Jan Engelhardt
2012-02-14 18:31     ` Bart De Schuymer
2012-02-14 19:56       ` Pablo Neira Ayuso
2012-02-21 12:32         ` Pablo Neira Ayuso

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4F341D0E.3020209@pandora.be \
    --to=bdschuym@pandora.be \
    --cc=joe@clnt.de \
    --cc=netfilter-devel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).