From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bart De Schuymer Subject: Re: [PATCH 2/3] netfilter: potential null derefence. Date: Fri, 02 Mar 2012 22:31:23 +0100 Message-ID: <4F513C2B.6030604@pandora.be> References: <1330593434-19275-1-git-send-email-santoshprasadnayak@gmail.com> <20120301123004.GA7250@1984> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="flowed" Content-Transfer-Encoding: 7bit Cc: santosh nayak , coreteam@netfilter.org, netdev@vger.kernel.org, bridge@lists.linux-foundation.org, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org, netfilter@vger.kernel.org, bart.de.schuymer@pandora.be, netfilter-devel@vger.kernel.org, shemminger@vyatta.com, davem@davemloft.net To: Pablo Neira Ayuso Return-path: In-Reply-To: <20120301123004.GA7250@1984> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: bridge-bounces@lists.linux-foundation.org Errors-To: bridge-bounces@lists.linux-foundation.org List-Id: netfilter-devel.vger.kernel.org Op 1/03/2012 13:30, Pablo Neira Ayuso schreef: > On Thu, Mar 01, 2012 at 02:47:14PM +0530, santosh nayak wrote: >> From: Santosh Nayak >> >> I am getting following error. >> " net/bridge/netfilter/ebtables.c:269 ebt_do_table() >> error: potential null derefence 'cs'" >> >> i = cs[sp].n; // If cs == Null then this will cause problem. > > Very sorry, I didn't see the out label. > > I'll apply this to my nf [1] once David takes my previous request for > pulling. > Hi, Has this patch been tested? Really, that code in the core firewall function is there for a reason, wouldn't you think? The chainstack is only allocated when user-defined chains are used (see translate_table). Never blindly trust a tool. Bart