From: Bart De Schuymer <bdschuym@pandora.be>
To: Florian Westphal <fw@strlen.de>
Cc: netfilter-devel <netfilter-devel@vger.kernel.org>
Subject: Re: [PATCH v2] bridge: netfilter: don't call iptables on vlan packets if sysctl is off
Date: Mon, 05 Mar 2012 18:02:20 +0100 [thread overview]
Message-ID: <4F54F19C.2050507@pandora.be> (raw)
In-Reply-To: <1330946020-25748-1-git-send-email-fw@strlen.de>
Op 5/03/2012 12:13, Florian Westphal schreef:
> When net.bridge.bridge-nf-filter-vlan-tagged is 0 (default), vlan packets
> arriving should not be sent to ip(6)tables by bridge netfilter.
> +#define IS_ARP(skb) \
> + (!vlan_tx_tag_present(skb)&& skb->protocol == htons(ETH_P_ARP))
> +
I could nitpick on the lack of a space before the && (it's also in other
places in your patch). Is that intentional? I've never seen this coding
style before and you don't seem to do it for ||.
Apart from that it's a very clean patch. I leave it up to you and Pablo
to decide if this needs to be changed before applying the patch.
Thanks,
Bart
--
Bart De Schuymer
www.artinalgorithms.be
next prev parent reply other threads:[~2012-03-05 17:02 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-05 11:13 [PATCH v2] bridge: netfilter: don't call iptables on vlan packets if sysctl is off Florian Westphal
2012-03-05 17:02 ` Bart De Schuymer [this message]
2012-03-05 21:02 ` Florian Westphal
2012-03-05 22:35 ` Pablo Neira Ayuso
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F54F19C.2050507@pandora.be \
--to=bdschuym@pandora.be \
--cc=fw@strlen.de \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).