From: Serge Leschinsky <serge.leschinsky@gmail.com>
To: Florian Westphal <fw@strlen.de>
Cc: Jan Engelhardt <jengelh@medozas.de>,
Netfilter Developer Mailing List
<netfilter-devel@vger.kernel.org>
Subject: Re: a possible bug in netfilter
Date: Sat, 07 Apr 2012 21:07:13 -0700 [thread overview]
Message-ID: <4F810EF1.1030209@gmail.com> (raw)
In-Reply-To: <20120407155847.GB28425@Chamillionaire.breakpoint.cc>
On 04/07/2012 08:58 AM, Florian Westphal wrote:
....
> Serge, could you try this patch?
>
> diff --git a/extensions/xt_psd.c b/extensions/xt_psd.c
> index 46b2831..acb5e8e 100644
> --- a/extensions/xt_psd.c
> +++ b/extensions/xt_psd.c
> @@ -227,7 +227,7 @@ xt_psd_match(const struct sk_buff *pskb, struct xt_action_param *match)
> goto out_match;
>
> /* Remember the new port */
> - if (curr->count< SCAN_MAX_COUNT) {
> + if (curr->count< ARRAY_SIZE(curr->ports)) {
> curr->ports[curr->count].number = dest_port;
> curr->ports[curr->count].proto = proto;
> curr->ports[curr->count].and_flags = tcp_flags;
>
The patch is applied. I'll monitor logs for about a week to make sure there are
no more panics.
Thank you!
Serge
next prev parent reply other threads:[~2012-04-08 4:07 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-06 4:12 a possible bug in netfilter Serge Leschinsky
2012-04-06 13:10 ` Jan Engelhardt
2012-04-07 15:58 ` Florian Westphal
2012-04-08 4:07 ` Serge Leschinsky [this message]
2012-04-17 22:20 ` Serge Leschinsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F810EF1.1030209@gmail.com \
--to=serge.leschinsky@gmail.com \
--cc=fw@strlen.de \
--cc=jengelh@medozas.de \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).