From mboxrd@z Thu Jan 1 00:00:00 1970 From: Gao feng Subject: Re: [PATCH 01/17] netfilter: add struct nf_proto_net for register l4proto sysctl Date: Fri, 25 May 2012 09:05:34 +0800 Message-ID: <4FBEDADE.8040905@cn.fujitsu.com> References: <1336985547-31960-1-git-send-email-gaofeng@cn.fujitsu.com> <1336985547-31960-2-git-send-email-gaofeng@cn.fujitsu.com> <20120523101200.GA2836@1984> <4FBD9076.6060309@cn.fujitsu.com> <20120524095859.GC13091@1984> <4FBE1372.60206@cn.fujitsu.com> <20120524143854.GA15898@1984> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Cc: netfilter-devel@vger.kernel.org, netdev@vger.kernel.org, serge.hallyn@canonical.com, ebiederm@xmission.com, dlezcano@fr.ibm.com, Gao feng To: Pablo Neira Ayuso Return-path: Received: from cn.fujitsu.com ([222.73.24.84]:43933 "EHLO song.cn.fujitsu.com" rhost-flags-OK-FAIL-OK-OK) by vger.kernel.org with ESMTP id S1754268Ab2EYBhj convert rfc822-to-8bit (ORCPT ); Thu, 24 May 2012 21:37:39 -0400 In-Reply-To: <20120524143854.GA15898@1984> Sender: netfilter-devel-owner@vger.kernel.org List-ID: =E4=BA=8E 2012=E5=B9=B405=E6=9C=8824=E6=97=A5 22:38, Pablo Neira Ayuso = =E5=86=99=E9=81=93: > On Thu, May 24, 2012 at 06:54:42PM +0800, Gao feng wrote: > [...] >>>>> I don't see why we need this new field. >>>>> >>>>> It seems to be set to 1 in each structure that has set: >>>>> >>>>> .ctl_compat_table >>>>> >>>>> to non-NULL. So, it's redundant. >>>>> >>>>> Moreover, you already know from the protocol tracker itself if yo= u >>>>> have to allocate the compat ctl table or not. >>>>> >>>>> In other words: You set compat to 1 for nf_conntrack_l4proto_gene= ric. >>>>> Then, you pass that compat value to generic_init_net via ->inet_n= et >>>>> again, but this information (that determines if the compat has to= be >>>>> done or not) is already in the scope of the protocol tracker. >>>>> >>>> >>>> because some protocols such l4proto_tcp6 and l4proto_tcp use the s= ame init_net >>>> function. the l4proto_tcp6 doesn't need compat sysctl, so we shoul= d use this new >>>> field to identify if we should kmemdup compat_sysctl_table. >>> >>> Then, could you use two init_net functions? one for TCP for IPv4 an= d another >>> for TCP for IPv6? >> >> Of cause, if you prefer to impletment it in this way. >=20 > If this removes the .compat field that you added, then use two > init_net functions, yes. Sorry I miss something. nf_ct_l4proto_unregister_sysctl also uses .compat to identify if we can unregister the compat sysctl. if we register l4proto_tcp and l4proto_tcp6 both. without .compat, when unregister l4proto_tcp6, the compat sysctl will be unregister too. So maybe we have to use .compat. -- To unsubscribe from this list: send the line "unsubscribe netfilter-dev= el" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html