From: Gao feng <gaofeng@cn.fujitsu.com>
To: Pablo Neira Ayuso <pablo@netfilter.org>
Cc: netfilter-devel@vger.kernel.org, netdev@vger.kernel.org,
serge.hallyn@canonical.com, ebiederm@xmission.com,
dlezcano@fr.ibm.com, Gao feng <gaofeng@cn.fujitus.com>
Subject: Re: [PATCH 01/15] netfilter: add namespace support for l4proto
Date: Wed, 06 Jun 2012 08:56:28 +0800 [thread overview]
Message-ID: <4FCEAABC.1050807@cn.fujitsu.com> (raw)
In-Reply-To: <20120605235600.GB27222@1984>
Hi pablo
于 2012年06月06日 07:56, Pablo Neira Ayuso 写道:
> On Tue, May 29, 2012 at 03:04:09PM +0800, Gao feng wrote:
>> From: Gao feng <gaofeng@cn.fujitus.com>
>>
>> struct nf_proto_net stroes proto's ctl_table_header and ctl_table,
>> nf_ct_l4proto_(un)register_sysctl use it to register sysctl.
>> because AF_INET6's protocols need not do compat, so register or
>> unregister sysctl when l4proto.l3proto != AF_INET6.
>>
>> - the net_id field is used to store the pernet_operations id
>> that belones to l4proto.
>>
>> - init_net will be used to initial the proto's pernet data
>>
>> - nf_ct_(un)register_sysctl are changed to support net namespace,
>> use (un)register_net_sysctl_table replaces (un)register_sysctl_paths.
>> and in nf_ct_unregister_sysctl,kfree table only when users is 0.
>>
>> - Add the struct net as param of nf_conntrack_l4proto_(un)register.
>> register or unregister the l4proto only when the net is init_net.
>>
>> - nf_conntrack_l4proto_register call init_net to initial the pernet
>> data of l4proto.
>>
>> - nf_ct_l4proto_net is used to get the pernet data of l4proto.
>>
>> - use init_net as a param of nf_conntrack_l4proto_(un)register.
>
> I have applied this patchset, but I had to rewrite the patch
> descriptions.
>
> I don't blame your English neither your writing abilities (I'm not
> native speaker and not that good at writing either) but I think you
> can make it better next time.
I apologize for my pool English and writing abilities.
Maybe I should take an english course...
>
> Basically, you don't need to comment every single change that the
> patch does. That's easy to see by looking at the patchset.
>
> Instead, just provide brief explanation on your intentions with the
> patch, clarify things that may look not obvious to the reviewer and
> what we'll get with this.
Got it, thanks for teaching me this. ;)
> --
> To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
--
To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2012-06-06 0:56 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-29 7:04 [PATCH 00/15] netfilter: add namespace support for netfilter proto Gao feng
2012-05-29 7:04 ` [PATCH 01/15] netfilter: add namespace support for l4proto Gao feng
2012-06-05 23:56 ` Pablo Neira Ayuso
2012-06-06 0:56 ` Gao feng [this message]
2012-05-29 7:04 ` [PATCH 02/15] netfilter: add namespace support for l3proto Gao feng
2012-05-29 7:04 ` [PATCH 03/15] netfilter: add namespace support for l4proto_generic Gao feng
2012-05-29 7:04 ` [PATCH 04/15] netfilter: add namespace support for l4proto_tcp Gao feng
2012-05-29 7:04 ` [PATCH 05/15] netfilter: add namespace support for l4proto_udp Gao feng
2012-05-29 7:04 ` [PATCH 06/15] netfilter: add namespace support for l4proto_icmp Gao feng
2012-05-29 7:04 ` [PATCH 07/15] netfilter: add namespace support for l4proto_icmpv6 Gao feng
2012-05-29 7:04 ` [PATCH 08/15] netfilter: add namespace support for l3proto_ipv4 Gao feng
2012-05-29 7:04 ` [PATCH 09/15] netfilter: add namespace support for l3proto_ipv6 Gao feng
2012-05-29 7:04 ` [PATCH 10/15] netfilter: add namespace support for l4proto_sctp Gao feng
2012-05-29 7:04 ` [PATCH 11/15] netfilter: add namespace support for l4proto_udplite Gao feng
2012-05-29 7:04 ` [PATCH 12/15] netfilter: adjust l4proto_dccp to the nf_conntrack_l4proto_register Gao feng
2012-05-29 7:04 ` [PATCH 13/15] netfilter: adjust l4proto_gre4 " Gao feng
2012-05-29 7:04 ` [PATCH 14/15] netfilter: cleanup sysctl for l4proto and l3proto Gao feng
2012-05-29 7:04 ` [PATCH 15/15] netfilter: add namespace support for cttimeout Gao feng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FCEAABC.1050807@cn.fujitsu.com \
--to=gaofeng@cn.fujitsu.com \
--cc=dlezcano@fr.ibm.com \
--cc=ebiederm@xmission.com \
--cc=gaofeng@cn.fujitus.com \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=pablo@netfilter.org \
--cc=serge.hallyn@canonical.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).