From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mr Dash Four Subject: Re: [PATCH 0/3] ipset: change 'iface' part in hash:net,iface set Date: Sun, 08 Jul 2012 23:25:18 +0100 Message-ID: <4FFA08CE.1090406@googlemail.com> References: <4FF736FE.8030109@googlemail.com> <4FF74868.3070303@googlemail.com> <4FF74D5C.6060909@googlemail.com> <4FF752F0.3010007@googlemail.com> <4FF765E7.6020809@googlemail.com> <4FF9852C.7080201@googlemail.com> <4FF9D97D.7040309@googlemail.com> <4FF9DB46.5000302@googlemail.com> <4FFA056C.8000709@googlemail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: Netfilter Core Team , Pablo Neira Ayuso , Patrick McHardy To: Jozsef Kadlecsik Return-path: Received: from mail-wg0-f44.google.com ([74.125.82.44]:57624 "EHLO mail-wg0-f44.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752402Ab2GHWZ2 (ORCPT ); Sun, 8 Jul 2012 18:25:28 -0400 Received: by wgbdr13 with SMTP id dr13so10854281wgb.1 for ; Sun, 08 Jul 2012 15:25:27 -0700 (PDT) In-Reply-To: Sender: netfilter-devel-owner@vger.kernel.org List-ID: >>> with your patches in some cases >>> "src,in" == "src,src" or "src,in" != "src,src" >>> >>> >> Could you provide me with an example please? I am intrigued! >> > > This is ridiculous, as if I haven't provided it countless times: > > iptables -A INPUT -m set --match-set list1 src,src -j ACCEPT > iptables -A INPUT -m set --match-set list1 src,in -j ACCEPT > Well, in the above example I fail to see where "src,in" == "src,src" - that is *never* the case! >> So, in other words, what you are actually getting at, is that you wish to >> restrict the use of 'in' and 'out' options only for hash:net,iface types >> because you are not happy with the use of 'in'/'out' in any other set types, >> list:set in particular? Have I understood this correctly then? >> > > That's a possible - probably the simplest - solution. It's OK for me. > So, let me get this straight then: you wish 'in' and 'out' to be accepted as input (and I presume also displayed as well) *only* for hash:net,iface type of sets and rejected (possibly with an error) everywhere else? In other words: 1. For hash:net,iface the possible options should be 'in', 'out', 'src' and 'dst'; and 2. For all other sets, including list:set the only available options should be 'src' and 'dst'. Have I understood this correctly then?