From: wenxu <wenxu@ucloud.cn>
To: Pablo Neira Ayuso <pablo@netfilter.org>
Cc: netfilter-devel@vger.kernel.org, nikolay@cumulusnetworks.com,
bridge@lists.linux-foundation.org
Subject: Re: [PATCH] netfilter: nft_meta: fix bridge port vlan ID selector
Date: Wed, 3 Jul 2019 22:59:47 +0800 [thread overview]
Message-ID: <4f3561be-adec-bda4-0e4f-d23ed82acf0f@ucloud.cn> (raw)
In-Reply-To: <20190703141507.mnhzqapu4iaan5d7@salvia>
Agree with you, After add the rcu patch I will resent the series fo nft_meta_bridge!.
在 2019/7/3 22:15, Pablo Neira Ayuso 写道:
> Hi,
>
> I'm planning to revert from nf-next
>
> da4f10a4265b netfilter: nft_meta: add NFT_META_BRI_PVID support
>
> because:
>
> * Nikolay wants us to use the helpers, however, through the existing
> approach this creates a dependency between nft_meta and the bridge
> module. I think I suggested this already, but it seems there is a
> need for nft_meta_bridge, otherwise nft_meta pulls in the bridge
> modules as a dependency.
>
> * NFT_META_BRI_PVID needs to be rename to NFT_META_BRI_IIFPVID.
>
> * We need new helpers to access this information from rcu path, I'm
> attaching a patch for such helper for review.
>
> so we take the time to get this right :-)
prev parent reply other threads:[~2019-07-03 15:00 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-03 12:40 [PATCH] netfilter: nft_meta: fix bridge port vlan ID selector Pablo Neira Ayuso
2019-07-03 12:42 ` Nikolay Aleksandrov
2019-07-03 12:48 ` Nikolay Aleksandrov
2019-07-03 12:53 ` Nikolay Aleksandrov
2019-07-03 12:58 ` Nikolay Aleksandrov
2019-07-03 13:53 ` wenxu
2019-07-03 14:15 ` Pablo Neira Ayuso
2019-07-03 14:52 ` Nikolay Aleksandrov
2019-07-03 14:59 ` wenxu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4f3561be-adec-bda4-0e4f-d23ed82acf0f@ucloud.cn \
--to=wenxu@ucloud.cn \
--cc=bridge@lists.linux-foundation.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=nikolay@cumulusnetworks.com \
--cc=pablo@netfilter.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).