From: rajesh <rajesh.modhwadiya@elitecore.com>
To: netfilter-devel@vger.kernel.org
Subject: replace nf_nat_seqofs_lock with spin_lock of nf_conn
Date: Tue, 31 Jul 2012 12:33:25 +0530 [thread overview]
Message-ID: <5017833D.9050107@elitecore.com> (raw)
Hi,
My kernel version is 2.6.32.
I have verify that same lock is also used in 3.4.6.
there is global spin lock at net/ipv4/netfilter/nf_nat_helper.c
static DEFINE_SPINLOCK(nf_nat_seqofs_lock);
this is used in following functions:
adjust_tcp_sequence();
nf_nat_get_offset();
This lock will reduce performance in case of multicore machines.
There is a spin_lock in nf_conn structure itself, which is used by
tcp_packet() at
net/netfilter/nf_conntrack_proto_tcp.c
and other places.
So can we replace
spin_lock_bh(&nf_nat_seqofs_lock);
with
spin_lock_bh(&ct->lock);
regards
rajesh
reply other threads:[~2012-07-31 7:04 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5017833D.9050107@elitecore.com \
--to=rajesh.modhwadiya@elitecore.com \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).