* replace nf_nat_seqofs_lock with spin_lock of nf_conn
@ 2012-07-31 7:03 rajesh
0 siblings, 0 replies; only message in thread
From: rajesh @ 2012-07-31 7:03 UTC (permalink / raw)
To: netfilter-devel
Hi,
My kernel version is 2.6.32.
I have verify that same lock is also used in 3.4.6.
there is global spin lock at net/ipv4/netfilter/nf_nat_helper.c
static DEFINE_SPINLOCK(nf_nat_seqofs_lock);
this is used in following functions:
adjust_tcp_sequence();
nf_nat_get_offset();
This lock will reduce performance in case of multicore machines.
There is a spin_lock in nf_conn structure itself, which is used by
tcp_packet() at
net/netfilter/nf_conntrack_proto_tcp.c
and other places.
So can we replace
spin_lock_bh(&nf_nat_seqofs_lock);
with
spin_lock_bh(&ct->lock);
regards
rajesh
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2012-07-31 7:04 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-07-31 7:03 replace nf_nat_seqofs_lock with spin_lock of nf_conn rajesh
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).