From: Jozsef Kadlecsik <kadlec@netfilter.org>
To: Wan Jiabing <wanjiabing@vivo.com>
Cc: Pablo Neira Ayuso <pablo@netfilter.org>,
Florian Westphal <fw@strlen.de>,
netfilter-devel@vger.kernel.org, coreteam@netfilter.org,
linux-kernel@vger.kernel.org, kael_w@yeah.net
Subject: Re: [PATCH] netfilter: ipset: Remove duplicate declaration
Date: Sun, 28 Mar 2021 21:30:49 +0200 (CEST) [thread overview]
Message-ID: <508fa09b-b2a2-b88f-35b1-d6d3d2a24254@netfilter.org> (raw)
In-Reply-To: <20210327025454.917202-1-wanjiabing@vivo.com>
On Sat, 27 Mar 2021, Wan Jiabing wrote:
> struct ip_set is declared twice. One is declared at 79th line,
> so remove the duplicate.
Yes, it's a duplicate. Pablo, could you apply it?
> Signed-off-by: Wan Jiabing <wanjiabing@vivo.com>
Acked-by: Jozsef Kadlecsik <kadlec@netfilter.org>
Best regards,
Jozsef
> ---
> include/linux/netfilter/ipset/ip_set.h | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/include/linux/netfilter/ipset/ip_set.h b/include/linux/netfilter/ipset/ip_set.h
> index 46d9a0c26c67..10279c4830ac 100644
> --- a/include/linux/netfilter/ipset/ip_set.h
> +++ b/include/linux/netfilter/ipset/ip_set.h
> @@ -124,8 +124,6 @@ struct ip_set_ext {
> bool target;
> };
>
> -struct ip_set;
> -
> #define ext_timeout(e, s) \
> ((unsigned long *)(((void *)(e)) + (s)->offset[IPSET_EXT_ID_TIMEOUT]))
> #define ext_counter(e, s) \
> --
> 2.25.1
>
>
-
E-mail : kadlec@blackhole.kfki.hu, kadlecsik.jozsef@wigner.hu
PGP key : https://wigner.hu/~kadlec/pgp_public_key.txt
Address : Wigner Research Centre for Physics
H-1525 Budapest 114, POB. 49, Hungary
next prev parent reply other threads:[~2021-03-28 19:32 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-27 2:54 [PATCH] netfilter: ipset: Remove duplicate declaration Wan Jiabing
2021-03-28 19:30 ` Jozsef Kadlecsik [this message]
2021-03-30 22:56 ` Pablo Neira Ayuso
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=508fa09b-b2a2-b88f-35b1-d6d3d2a24254@netfilter.org \
--to=kadlec@netfilter.org \
--cc=coreteam@netfilter.org \
--cc=fw@strlen.de \
--cc=kael_w@yeah.net \
--cc=linux-kernel@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=pablo@netfilter.org \
--cc=wanjiabing@vivo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).