From: Mr Dash Four <mr.dash.four@googlemail.com>
To: Netfilter Core Team <netfilter-devel@vger.kernel.org>
Subject: Re: [PATCH] pgsql: add SSL connection implementation to PGSQL plugin
Date: Sat, 10 Nov 2012 23:17:31 +0000 [thread overview]
Message-ID: <509EE08B.80805@googlemail.com> (raw)
In-Reply-To: <1352277668.3652.43.camel@tourtet>
Eric Leblond wrote:
> Hello,
>
> Le lundi 03 septembre 2012 à 13:00 +0100, Mr Dash Four a écrit :
>>>> Sure. Are there any (other) objections to the patch I submitted?
>>>>
>>> I've applied the current patch to give it a run. And it shows a lot of
>>> whitespace errors. You'll need to fix it too.
>>>
>> What do you mean by that?
>
> There's a lot of spaces at end of lines or empty lines containing only
> spaces. Basically, s/ +$// to fix it.
I see. The patch I submitted over 2 months ago was based on the (then) newest git tree. From that tree, the 2 files I modified were output/pgsql/ulogd_output_PGSQL.c and ulogd.conf.in.
By looking at my patch, it is quite evident that the white space "errors", as you call them, originate mostly from the existing source in that git tree. In cases where I have introduced new "errors", these were caused by cut-and-paste from the original source after applying the modifications I needed done for the patch to fulfil its purpose.
Even today, the present version of ulogd_output_PGSQL.c and ulogd.conf.in in the current ulogd2 git tree has "a lot of whitespace errors" in them, even without my patch being applied.
A simple search for such "errors" in output/pgsql/ulogd_output_PGSQL.c alone produces 15 matches.
I suspect if I run similar searches on the entire ulogd2 tree (or any other tree within netfilter.org for that matter), the results won't be any different. Since you and Pablo are the maintainers of that tree, I am assuming that these "errors" were good enough for you when you patched these files in the past.
Why is that? What's changed?
Am I supposed to run a clean sweep of the entire existing git tree before submitting any patches, so that they meet with your and Pablo's approval then? I won't even go into the 2 months it took for the above response to finally arrive.
--
To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2012-11-10 23:17 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-01 12:51 [PATCH] pgsql: add SSL connection implementation to PGSQL plugin Mr Dash Four
2012-09-02 15:49 ` Eric Leblond
2012-09-02 16:24 ` Mr Dash Four
2012-09-02 23:32 ` Pablo Neira Ayuso
2012-09-03 1:38 ` Mr Dash Four
2012-09-03 6:33 ` Eric Leblond
2012-09-03 12:00 ` Mr Dash Four
2012-11-07 8:41 ` Eric Leblond
2012-11-10 23:17 ` Mr Dash Four [this message]
2012-09-18 19:28 ` Pablo Neira Ayuso
2012-09-20 22:33 ` Mr Dash Four
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=509EE08B.80805@googlemail.com \
--to=mr.dash.four@googlemail.com \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).